-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/tools/bazel_testing: provide a way to configure C toolchain in tests #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go_bazel_tests that require cgo have been failing on Windows since the test environment hasn't been passing additional flags needed to configure the C toolchain on Windows. This CL adds GO_BAZEL_TEST_BAZELFLAGS, an environment variable to be set with --test_env, which provides a list of additional flags to Bazel. Fixes bazel-contrib#2507
jayconrod
pushed a commit
that referenced
this pull request
May 27, 2020
…ts (#2509) go_bazel_tests that require cgo have been failing on Windows since the test environment hasn't been passing additional flags needed to configure the C toolchain on Windows. This CL adds GO_BAZEL_TEST_BAZELFLAGS, an environment variable to be set with --test_env, which provides a list of additional flags to Bazel. Fixes #2507
Looks like this change broke tests on Windows:
|
jayconrod
pushed a commit
to jayconrod/rules_go
that referenced
this pull request
May 28, 2020
Test case was added in bazel-contrib#2502. bazel-contrib#2509 enabled tests and caused it to start failing. Skipped for now. Updates bazel-contrib#2518
jayconrod
pushed a commit
that referenced
this pull request
May 28, 2020
jayconrod
pushed a commit
that referenced
this pull request
May 28, 2020
@meteorcloudy #2519 skips the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go_bazel_tests that require cgo have been failing on Windows since the
test environment hasn't been passing additional flags needed to
configure the C toolchain on Windows.
This CL adds GO_BAZEL_TEST_BAZELFLAGS, an environment variable to be
set with --test_env, which provides a list of additional flags to
Bazel.
Fixes #2507