CGO merged directory should have usable name. #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgo2 merges sources and generated code under a common directory, however this directory is anonymous. This breaks nogo's ability to easily include/exclude files as only the file's basename is retained. This change embeds cgo/packagePath into the merged directory to make it easy to include/exclude sources being compiled by cgo. Note: PR bazel-contrib#2863 ensured that files //line: directives had their meaningful alt names included in nogo output, however cgo2's copy and link steps do not add that directive (pieces of the toolchain do), making certain files still challenging to include/exclude.
|
Thank you for the contribution with unit tests! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cgo2 merges sources and generated code under a common directory, however this directory is anonymous.
This breaks nogo's ability to easily include/exclude files as only the file's basename is retained.
This change embeds cgo/packagePath into the merged directory to make it easy to include/exclude sources being compiled by cgo.
Note: PR #2863 ensured that files //line: directives had their meaningful alt names included in nogo output. This is helpful, however for pure go files that are part of a package that uses cgo, there is nothing that adds //line: directives, and the builder will just copy/link pure files into the into the merged cgo folder.
What type of PR is this?
What does this PR do? Why is it needed?
Makes the merged cgo temp directory include the package path for easy inclusion/exclusion from nogo rules.
Which issues(s) does this PR fix?
Fixes # 2862
Other notes for review