Make go_test() with embedsrcs work #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though there already is testing coverage for go_test() with embedsrcs using generated files and such, I can't seem to get one of the most trivial cases to work. The file to be embedded doesn't get placed in the sandbox during GoCompilePkg. This change addresses this by explicitly copying the embedsrcs from the internal source to the external, which seems to make things work properly.
|
It's surprising that this wasn't caught by the existing embedsrcs_test, which also embeds files outside the directory, but I've confirmed that fact locally. Thanks for the contribution, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though there already is testing coverage for go_test() with
embedsrcs using generated files and such, I can't seem to get one of the
most trivial cases to work. The file to be embedded doesn't get placed
in the sandbox during GoCompilePkg.
This change addresses this by explicitly copying the embedsrcs from the
internal source to the external, which seems to make things work
properly.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
It fixes go_test() with embedsrcs. It's needed, because I want to use that feature.
Which issues(s) does this PR fix?
I couldn't find any existing issues.
Other notes for review