Find embedsrcs built in different configurations #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, embedsrcs under configuration roots different from that of the Go target itself or its source files weren't found. This is fixed by considering all combinations of roots of embedsrcs and root-relative paths of source files and compilation outputs.
fmeum
force-pushed
the
fix-embedsrc-config-roots
branch
from
6f21523 to
102f5af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Previously, embedsrcs under configuration roots different from that of
the Go target itself or its source files weren't found.
This is fixed by considering all combinations of roots of embedsrcs and
root-relative paths of source files and compilation outputs.
Which issues(s) does this PR fix?
Fixes #3114
Other notes for review
This blocks #3108, which causes the underlying bug to manifest itself in many simple situations.