Fix include paths for CGo deps in external repositories #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmicklas
reviewed
Apr 15, 2022
A CGo-generated header file from any repository, external or main, must always be includeable via its path relative to its repository root. Previously, this was not true for CGo targets in external repositories, which required an additional `external/<repo name>/` prefix, thus breaking references within the external repository. Fixes bazel-contrib#3109
fmeum
force-pushed
the
3109-fix-external-include-paths
branch
from
76c459c to
4a6060f
Compare
kmicklas
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
A CGo-generated header file from any repository, external or main, must
always be includeable via its path relative to its repository root.
Previously, this was not true for CGo targets in external repositories,
which required an additional
external/<repo name>/prefix, thusbreaking references within the external repository.
Which issues(s) does this PR fix?
Fixes #3109
Other notes for review