compilepkg: fix race when run without sandbox

go/private/actions/compilepkg.bzl

@@ -99,6 +99,7 @@ def emit_compilepkg(
         args.add("-cover_format", go.cover_format)
         args.add_all(cover, before_each = "-cover")
     args.add_all(archives, before_each = "-arc", map_each = _archive)
+    args.add("-label_name", go.label.name)
     if importpath:
         args.add("-importpath", importpath)
     if importmap:

go/tools/builders/compilepkg.go

@@ -42,7 +42,7 @@ func compilePkg(args []string) error {
 	goenv := envFlags(fs)
 	var unfilteredSrcs, coverSrcs, embedSrcs, embedLookupDirs, embedRoots multiFlag
 	var deps archiveMultiFlag
-	var importPath, packagePath, nogoPath, packageListPath, coverMode string
+	var labelName, importPath, packagePath, nogoPath, packageListPath, coverMode string
 	var outPath, outFactsPath, cgoExportHPath string
 	var testFilter string
 	var gcFlags, asmFlags, cppFlags, cFlags, cxxFlags, objcFlags, objcxxFlags, ldFlags quoteMultiFlag
@@ -63,6 +63,7 @@ func compilePkg(args []string) error {
 	fs.Var(&objcFlags, "objcflags", "Objective-C compiler flags")
 	fs.Var(&objcxxFlags, "objcxxflags", "Objective-C++ compiler flags")
 	fs.Var(&ldFlags, "ldflags", "C linker flags")
+	fs.StringVar(&labelName, "label_name", "", "The label's name")
 	fs.StringVar(&nogoPath, "nogo", "", "The nogo binary. If unset, nogo will not be run.")
 	fs.StringVar(&packageListPath, "package_list", "", "The file containing the list of standard library packages")
 	fs.StringVar(&coverMode, "cover_mode", "", "The coverage mode to use. Empty if coverage instrumentation should not be added.")
@@ -123,6 +124,7 @@ func compilePkg(args []string) error {
 
 	return compileArchive(
 		goenv,
+		labelName,
 		importPath,
 		packagePath,
 		srcs,
@@ -152,6 +154,7 @@ func compilePkg(args []string) error {
 
 func compileArchive(
 	goenv *env,
+	labelName string,
 	importPath string,
 	packagePath string,
 	srcs archiveSrcs,
@@ -176,8 +179,8 @@ func compileArchive(
 	outPath string,
 	outXPath string,
 	cgoExportHPath string,
-	coverFormat string) error {
-
+	coverFormat string,
+) error {
 	workDir, cleanup, err := goenv.workDir()
 	if err != nil {
 		return err
@@ -188,19 +191,28 @@ func compileArchive(
 		// We need to run the compiler to create a valid archive, even if there's
 		// nothing in it. GoPack will complain if we try to add assembly or cgo
 		// objects.
+		//
 		// _empty.go needs to be in a deterministic location (not tmpdir) in order
-		// to ensure deterministic output
-		emptyPath := filepath.Join(filepath.Dir(outPath), "_empty.go")
+		// to ensure deterministic output. The location also needs to be unique
+		// otherwise platforms without sandbox support may race to create/remove
+		// the file during parallel compilation.
+		emptyDir := filepath.Join(filepath.Dir(outPath), labelName)
+		err := os.Mkdir(emptyDir, 0700)
+		if err != nil {
+			return err
+		}
+		defer os.RemoveAll(emptyDir)
+		emptyPath := filepath.Join(emptyDir, "_empty.go")
 		if err := os.WriteFile(emptyPath, []byte("package empty\n"), 0666); err != nil {
 			return err
 		}
+
 		srcs.goSrcs = append(srcs.goSrcs, fileInfo{
 			filename: emptyPath,
 			ext:      goExt,
 			matched:  true,
 			pkg:      "empty",
 		})
-		defer os.Remove(emptyPath)
 	}
 	packageName := srcs.goSrcs[0].pkg
 	var goSrcs, cgoSrcs []string
@@ -416,8 +428,8 @@ func compileArchive(
 	// Compile the .s files.
 	if len(srcs.sSrcs) > 0 {
 		includeSet := map[string]struct{}{
-			filepath.Join(os.Getenv("GOROOT"), "pkg", "include"): struct{}{},
-			workDir: struct{}{},
+			filepath.Join(os.Getenv("GOROOT"), "pkg", "include"): {},
+			workDir: {},
 		}
 		for _, hdr := range srcs.hSrcs {
 			includeSet[filepath.Dir(hdr.filename)] = struct{}{}

tests/core/go_test/BUILD.bazel

@@ -195,6 +195,19 @@ go_library(
     deps = [":indirect_import_lib"],
 )
 
+[
+    go_test(
+        name = "same_package_{}_test".format(i),
+        srcs = ["same_package_test.go"],
+    )
+    for i in range(1, 80)
+]
+
+test_suite(
+    name = "same_package_test",
+    tests = ["same_package_{}_test".format(i) for i in range(1, 80)],
+)
+
 go_bazel_test(
     name = "testmain_without_exit_test",
     srcs = ["testmain_without_exit_test.go"],

tests/core/go_test/same_package_test.go

@@ -0,0 +1,7 @@
+package same_package
+
+import (
+	"testing"
+)
+
+func OkTest(t *testing.T) {}