Runfile port windows #3253
Closed
Runfile port windows #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today rules_go provide //go/tools/bazel as the canonical runfiles library for binaries to be executed with `bazel test` and `bazel run`. However, the current implementation pre-date the recent changes in Bazel's upstream. Since then, all of the native runfiles library of Bash, Java, CPP, Python have been refactored to follow a certain convention in locating files. (1) Although these are subjected to change with the incoming BzlMod feature, it would be easier to maintain if we can keep rules_go's runfiles library implementation aligned with native languages' implementation. Today, it seems like https://github.com/phst/runfiles implemented exactly that. So with @fmeum suggestion and @phst permission (2), let's port the newer, more accurate implementation to rules_go. Future refactoring will mark the current exported APIs in //go/tools/bazel as deprecated and/or swapping out the old implementation underneath to use this newer package. Changes in this PR included: - Copy paste repository over - Removal of .git and .gitignore and .githooks dir - Removal of repository specific files: README, WORKSPACE - Rename BUILD to BUILD.bazel - Rename import path for both go and BUILD files - Run gazelle over the packages - Adjusted test cases to reflect new package paths - Removed godoc related to installation instruction - Fixed test to handle window path separator - Updated canonical path criterias - Replaced usages of 'path' with 'path/filepath' Note that some issues with windows still remain unresolved. (1): https://docs.google.com/document/d/e/2PACX-1vSDIrFnFvEYhKsCMdGdD40wZRBX3m3aZ5HhVj4CtHPmiXKDCxioTUbYsDydjKtFDAzER5eg7OjJWs3V/pub (2): phst/runfiles#3 (comment)
fmeum
force-pushed
the
runfile-port-windows
branch
5 times, most recently
from
d94c068 to
19ee5fd
Compare
fmeum
force-pushed
the
runfile-port-windows
branch
from
19ee5fd to
9cd8f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the tests in #3205