Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Go SDK version out of go version instead of VERSION #3296

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Parse Go SDK version out of go version instead of VERSION #3296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions go/private/sdk.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,13 +302,18 @@ def _detect_sdk_platform(ctx, goroot):
return platforms[0]

def _detect_sdk_version(ctx, goroot):
path = goroot + "/VERSION"
version_contents = ctx.read(path)

# VERSION file has version prefixed by go, eg. go1.18.3
version = version_contents[2:]
go_binary_path = goroot + "/bin/go"
result = ctx.execute([go_binary_path, "version"])
if result.return_code != 0:
fail("Could not detect SDK version: '%s version' exited with exit code %d" % (go_binary_path, result.return_code))

# go version output is of the form "go version go1.18.3 linux/amd64"
output_parts = result.stdout.split(" ")
if len(output_parts) < 3 or not output_parts[2].startswith("go"):
fail("Could not parse SDK version from '%s version' output: %s" % (go_binary_path, result.stdout))
version = output_parts[2][len("go"):]
if _parse_version(version) == None:
fail("Could not parse SDK version from version file (%s): %s" % (path, version_contents))
fail("Could not parse SDK version from '%s version' output: %s" % (go_binary_path, result.stdout))
return version

def _parse_versions_json(data):
Expand Down