-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated rules #3538
Remove deprecated rules #3538
Conversation
4529db6
to
f4280f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since 0.39.0 contained so many fixes and improvements for Bzlmod, we didn't want to tie it to the removals.
I will hold onto merging this until the patch release is out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, but can you give us a bit more time in removing bindata in Uber? @tyler-french is working on it.
I don't think there is any rush in applying this patch. So if it takes a few days for Uber to sort out the bindata removal, then it should be fine. Or if you want me to split the bindata removal into a separate PR to merge separately, do let me know. |
Let's wait and land this, so you don't need to do hair splitting |
@linzhp any update on this? |
@uberzzr is steadily making progress in the internal migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are done with the migration. Thanks for the patience
There seem to be some network flake that affected auto merge here. Please try again 🙏 |
@sluongng The link variant of the path test is still failing. Could you send a separate PR to disable it? We know it's unsound. |
Yup, reasonable #3559 |
Head branch was pushed to by a user without write access
2fb55f9
to
fc95a69
Compare
@fmeum I rebased this PR on top of master. We should get it merged this time considering the |
That's my thought too |
These rules should have been removed in 0.39 release but were not.
fc95a69
to
48a4b2f
Compare
@linzhp I will merge this now that 0.41.0 is out. |
What type of PR is this?
Other
What does this PR do? Why is it needed?
These rules should have been removed in 0.39 release but were not.
Which issues(s) does this PR fix?
Fixes #
Other notes for review