Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation_outputs_test on Windows with Bazel@HEAD #3623

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Jul 13, 2023

Bazel now adds the repo mapping manifest to runfiles. It shows up in the output of ListRunfiles on Windows, where it should be ignored.

Fixes #3597

Bazel now adds the repo mapping manifest to runfiles. It shows up in the
output of `ListRunfiles` on Windows, where it should be ignored.
@fmeum fmeum force-pushed the 3597-fix-compilation-outputs-windows-runfiles branch from 55ef56f to a2b9dd5 Compare July 13, 2023 08:50
@fmeum fmeum enabled auto-merge (squash) July 13, 2023 08:53
@fmeum fmeum changed the title Fix compilation_outputs_test on Windows with latest Bazel Fix compilation_outputs_test on Windows with Bazel@HEAD Jul 13, 2023
@fmeum
Copy link
Member Author

fmeum commented Jul 13, 2023

FYI @linzhp

@fmeum fmeum merged commit d2a3cf2 into master Jul 13, 2023
@fmeum fmeum deleted the 3597-fix-compilation-outputs-windows-runfiles branch July 13, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR FAILED: //tests/core/transition:hermeticity_test with Bazel@HEAD in Downstream CI
1 participant