Fix //go/config:linkmode flag value not being effective
#3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
3614-linkmode
branch
2 times, most recently
from
256d30e to
4068a01
Compare
|
lgtm I also validated that gazelle is built with linkmode set to "pie" when |
HakanSunay
approved these changes
Jul 17, 2023
linzhp
approved these changes
Jul 18, 2023
|
@fmeum, I forgot to point out that this issue is present for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
The value of the flag was always overriden by the
linkmodego_binaryattribute, even if that attribute was at its default (normal) value. Instead, use a default ofautoto distinguish this case from the case where no attribute value has been set explicitly.Which issues(s) does this PR fix?
Fixes #3614
Closes #3615
Other notes for review