go_context: set GOTOOLCHAIN to 'local' #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested changes
Aug 15, 2023
sluongng
force-pushed
the
sluongng/go-toolchain-local
branch
from
afdd765 to
b786e7b
Compare
fmeum
approved these changes
Aug 15, 2023
Enforce usage of the current toolchain and avoid downloading new toolchains during build.
fmeum
force-pushed
the
sluongng/go-toolchain-local
branch
from
b786e7b to
e0dac32
Compare
sluongng
added a commit
to buildbuddy-io/buildbuddy
that referenced
this pull request
Aug 28, 2023
Upgrade rules_go to latest commit in `master` at the moment of writing. Unblocks Go 1.21 upgrade in #4516 by including the fixes in: - bazel-contrib/rules_go#3660 - bazel-contrib/rules_go#3666
sluongng
added a commit
to buildbuddy-io/buildbuddy
that referenced
this pull request
Aug 29, 2023
Upgrade rules_go to latest commit in `master` at the moment of writing. Unblocks Go 1.21 upgrade in #4516 by including the fixes in: - bazel-contrib/rules_go#3660 - bazel-contrib/rules_go#3666
ghost
mentioned this pull request
fmeum
pushed a commit
to bazel-contrib/bazel-gazelle
that referenced
this pull request
Aug 12, 2024
**What type of PR is this?** Bug fix **What package or component does this PR mostly affect?** go_repository_cache **What does this PR do? Why is it needed?** Override the **GOTOOLCHAIN** local environment parameter defined by `go env -w` to use the local Go environment made available by `gazelle`. **Which issues(s) does this PR fix?** Fixes #1858 **Other notes for review** Same fix than bazel-contrib/rules_go#3660 in [rules_go](https://github.com/bazelbuild/rules_go).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce usage of the current toolchain and avoid downloading new
toolchains during build.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review