Mark go_sdk module extension as {os,arch}_dependent
#3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the lockfile maintains separate instances of this extension for each OS/arch combination.
linzhp
reviewed
Sep 20, 2023
fmeum
commented
Sep 20, 2023
linzhp
approved these changes
Sep 20, 2023
|
Hi folks, maybe I should ask the question in bazelbuild/bazel, but do you know if there's any way to cross-build a lockfile for all available architectures after this change? When I do it normally I only get an entry for my own os/arch, which makes it quite difficult to update, as I would have to rebuild lockfile on each of them sequentially... |
|
@tpasternak There isn't and given that a module extension can run essentially arbitrary binaries, this can't be done. I'm looking into ways to resolve the situation for |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This ensures that the lockfile maintains separate instances of this extension for each OS/arch combination.