Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer importpath if not set explicitly #3705

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

mering
Copy link
Contributor

@mering mering commented Sep 21, 2023

What type of PR is this?

Feature

What does this PR do? Why is it needed?

This infers the importpath automatically if it is not set. If set explicitly it continues to use this one.

Which issues(s) does this PR fix?

Other notes for review

@mering mering force-pushed the importpath branch 2 times, most recently from c4e878f to 84d9478 Compare September 21, 2023 20:55
Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@linzhp Do you have any concerns?

go/private/context.bzl Outdated Show resolved Hide resolved
Copy link
Contributor

@linzhp linzhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linzhp linzhp enabled auto-merge (squash) September 25, 2023 14:51
@linzhp linzhp disabled auto-merge September 25, 2023 14:52
@linzhp linzhp enabled auto-merge (squash) September 27, 2023 05:51
@linzhp linzhp merged commit d1da1bb into bazel-contrib:master Sep 27, 2023
1 check passed
@mering mering deleted the importpath branch September 27, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants