Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bazel_features polyfill to prevent conflicts #3817

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Jan 7, 2024

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?

Fixes #3816

Other notes for review

@fmeum fmeum requested a review from tyler-french January 7, 2024 10:19
@fmeum
Copy link
Member Author

fmeum commented Jan 7, 2024

CC @illicitonion

@fmeum fmeum force-pushed the 3816-features-rename branch from 4dc7620 to fa04285 Compare January 7, 2024 20:37
@fmeum fmeum enabled auto-merge (squash) January 7, 2024 20:38
@fmeum fmeum merged commit 3c51b96 into master Jan 7, 2024
5 checks passed
@fmeum fmeum deleted the 3816-features-rename branch January 7, 2024 20:58
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/bazel-starlib Jan 12, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.44.2` -> `v0.45.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.45.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.44.2...v0.45.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"de7974538c31f76658e0d333086c69efdf6679dbc6a466ac29e65434bf47076d",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.21.6")

#### What's Changed

- nogo: use original source files instead of coverage-instrumented by
[@&#8203;emmaxy](https://togithub.com/emmaxy) in
[https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770)
- Allow compilers to be overwritten in go_grpc_library() by
[@&#8203;mering](https://togithub.com/mering) in
[https://github.com/bazelbuild/rules_go/pull/3812](https://togithub.com/bazelbuild/rules_go/pull/3812)
- update documentation for 0.44 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3813](https://togithub.com/bazelbuild/rules_go/pull/3813)
- Temporarily undo deprecation of `//proto:go_grpc` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3818](https://togithub.com/bazelbuild/rules_go/pull/3818)
- Rename bazel_features polyfill to prevent conflicts by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3817](https://togithub.com/bazelbuild/rules_go/pull/3817)
- Handle prerelease versions in polyfill by
[@&#8203;illicitonion](https://togithub.com/illicitonion) in
[https://github.com/bazelbuild/rules_go/pull/3821](https://togithub.com/bazelbuild/rules_go/pull/3821)
- Extend gomock to allow passing an source_importpath instead of library
when operating in source mode by
[@&#8203;therve](https://togithub.com/therve) in
[https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822)
- Fix coverage collection with modified `COVERAGE_DIR` env variable by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3820](https://togithub.com/bazelbuild/rules_go/pull/3820)
- improving logging for subcommand failure by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[https://github.com/bazelbuild/rules_go/pull/3824](https://togithub.com/bazelbuild/rules_go/pull/3824)
- release rules go 0.45.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3825](https://togithub.com/bazelbuild/rules_go/pull/3825)

#### New Contributors

- [@&#8203;emmaxy](https://togithub.com/emmaxy) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770)
- [@&#8203;therve](https://togithub.com/therve) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822)

**Full Changelog**:
bazel-contrib/rules_go@v0.44.2...v0.45.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot referenced this pull request in kreempuff/rules_unreal_engine Jan 12, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.44.2` -> `v0.45.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.45.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.44.2...v0.45.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"de7974538c31f76658e0d333086c69efdf6679dbc6a466ac29e65434bf47076d",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.21.6")

#### What's Changed

- nogo: use original source files instead of coverage-instrumented by
[@&#8203;emmaxy](https://togithub.com/emmaxy) in
[https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770)
- Allow compilers to be overwritten in go_grpc_library() by
[@&#8203;mering](https://togithub.com/mering) in
[https://github.com/bazelbuild/rules_go/pull/3812](https://togithub.com/bazelbuild/rules_go/pull/3812)
- update documentation for 0.44 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3813](https://togithub.com/bazelbuild/rules_go/pull/3813)
- Temporarily undo deprecation of `//proto:go_grpc` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3818](https://togithub.com/bazelbuild/rules_go/pull/3818)
- Rename bazel_features polyfill to prevent conflicts by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3817](https://togithub.com/bazelbuild/rules_go/pull/3817)
- Handle prerelease versions in polyfill by
[@&#8203;illicitonion](https://togithub.com/illicitonion) in
[https://github.com/bazelbuild/rules_go/pull/3821](https://togithub.com/bazelbuild/rules_go/pull/3821)
- Extend gomock to allow passing an source_importpath instead of library
when operating in source mode by
[@&#8203;therve](https://togithub.com/therve) in
[https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822)
- Fix coverage collection with modified `COVERAGE_DIR` env variable by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3820](https://togithub.com/bazelbuild/rules_go/pull/3820)
- improving logging for subcommand failure by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[https://github.com/bazelbuild/rules_go/pull/3824](https://togithub.com/bazelbuild/rules_go/pull/3824)
- release rules go 0.45.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3825](https://togithub.com/bazelbuild/rules_go/pull/3825)

#### New Contributors

- [@&#8203;emmaxy](https://togithub.com/emmaxy) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770)
- [@&#8203;therve](https://togithub.com/therve) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822)

**Full Changelog**:
bazel-contrib/rules_go@v0.44.2...v0.45.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Jan 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.44.2` -> `v0.45.1` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.45.1`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.1)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.45.0...v0.45.1)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"6734a719993b1ba4ebe9806e853864395a8d3968ad27f9dd759c196b3eb3abe8",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.21.6")

#### What's Changed

- Disable `layering_check` feature in CGo tests by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3829](https://togithub.com/bazelbuild/rules_go/pull/3829)
- Print stack traces without panicking on test timeout by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3833](https://togithub.com/bazelbuild/rules_go/pull/3833)
- Fix regression in empty `.go` file filtering for nogo by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3832](https://togithub.com/bazelbuild/rules_go/pull/3832)
- release patch version 0.45.1 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3836](https://togithub.com/bazelbuild/rules_go/pull/3836)

**Full Changelog**:
bazel-contrib/rules_go@v0.45.0...v0.45.1

###
[`v0.45.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.45.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.44.2...v0.45.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"de7974538c31f76658e0d333086c69efdf6679dbc6a466ac29e65434bf47076d",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.21.6")

#### What's Changed

- nogo: use original source files instead of coverage-instrumented by
[@&#8203;emmaxy](https://togithub.com/emmaxy) in
[https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770)
- Allow compilers to be overwritten in go_grpc_library() by
[@&#8203;mering](https://togithub.com/mering) in
[https://github.com/bazelbuild/rules_go/pull/3812](https://togithub.com/bazelbuild/rules_go/pull/3812)
- update documentation for 0.44 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3813](https://togithub.com/bazelbuild/rules_go/pull/3813)
- Temporarily undo deprecation of `//proto:go_grpc` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3818](https://togithub.com/bazelbuild/rules_go/pull/3818)
- Rename bazel_features polyfill to prevent conflicts by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3817](https://togithub.com/bazelbuild/rules_go/pull/3817)
- Handle prerelease versions in polyfill by
[@&#8203;illicitonion](https://togithub.com/illicitonion) in
[https://github.com/bazelbuild/rules_go/pull/3821](https://togithub.com/bazelbuild/rules_go/pull/3821)
- Extend gomock to allow passing an source_importpath instead of library
when operating in source mode by
[@&#8203;therve](https://togithub.com/therve) in
[https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822)
- Fix coverage collection with modified `COVERAGE_DIR` env variable by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3820](https://togithub.com/bazelbuild/rules_go/pull/3820)
- improving logging for subcommand failure by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[https://github.com/bazelbuild/rules_go/pull/3824](https://togithub.com/bazelbuild/rules_go/pull/3824)
- release rules go 0.45.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3825](https://togithub.com/bazelbuild/rules_go/pull/3825)

#### New Contributors

- [@&#8203;emmaxy](https://togithub.com/emmaxy) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3770](https://togithub.com/bazelbuild/rules_go/pull/3770)
- [@&#8203;therve](https://togithub.com/therve) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3822](https://togithub.com/bazelbuild/rules_go/pull/3822)

**Full Changelog**:
bazel-contrib/rules_go@v0.44.2...v0.45.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change on v0.44.1 -> v0.44.2 with missing bazel_features dependency
2 participants