Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go vet with latest analyzers #3902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update go vet with latest analyzers
Upgrade golang.org/x/tools to v0.18.0.
Note that the latest v0.19.0 has a bug that we should avoid using.

Update the analyzers (passes) in TOOLS_NOGO and the ones automatically
included when `vet = True` is configured.
The vet analyzers are taken from `go tool vet help` documentation.
sluongng committed Mar 27, 2024
commit 05860f687b6a449494c53b7d1b5fa120838ed5b9
6 changes: 4 additions & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
@@ -71,6 +71,8 @@ bazel_skylib_workspace()

http_archive(
name = "bazel_gazelle",
patch_args = ["-p1"],
patches = ["//third_party:bazel-gazelle.patch"],
sha256 = "b7387f72efb59f876e4daae42f1d3912d0d45563eac7cb23d1de0b094ab588cf",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/bazel-gazelle/releases/download/v0.34.0/bazel-gazelle-v0.34.0.tar.gz",
@@ -99,8 +101,8 @@ go_repository(
go_repository(
name = "org_golang_x_mod",
importpath = "golang.org/x/mod",
sum = "h1:KENHtAZL2y3NLMYZeHY9DW8HW8V+kQyJsY/V9JlKvCs=",
version = "v0.9.0",
sum = "h1:SernR4v+D55NyBH2QiEQrlBAnj1ECL6AGrA5+dPaMY8=",
version = "v0.15.0",
)

go_repository(
8 changes: 4 additions & 4 deletions go.mod
Original file line number Diff line number Diff line change
@@ -6,16 +6,16 @@ require (
github.com/gogo/protobuf v1.3.2
github.com/golang/mock v1.7.0-rc.1
github.com/golang/protobuf v1.5.3
golang.org/x/net v0.18.0
golang.org/x/tools v0.15.0
golang.org/x/net v0.21.0
golang.org/x/tools v0.18.0
google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013
google.golang.org/grpc v1.40.1
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0
google.golang.org/protobuf v1.31.0
)

require (
golang.org/x/mod v0.14.0 // indirect
golang.org/x/sys v0.15.0 // indirect
golang.org/x/mod v0.15.0 // indirect
golang.org/x/sys v0.18.0 // indirect
golang.org/x/text v0.14.0 // indirect
)
20 changes: 10 additions & 10 deletions go.sum
Original file line number Diff line number Diff line change
@@ -68,8 +68,8 @@ golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3/go.mod h1:6SW0HCj/g11FgYtHl
golang.org/x/mod v0.2.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
golang.org/x/mod v0.5.1/go.mod h1:5OXOZSfqPIIbmVBIIKWRFfZjPR0E5r58TLhUjH0a2Ro=
golang.org/x/mod v0.14.0 h1:dGoOF9QVLYng8IHTm7BAyWqCqSheQ5pYWGhzW00YJr0=
golang.org/x/mod v0.14.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
golang.org/x/mod v0.15.0 h1:SernR4v+D55NyBH2QiEQrlBAnj1ECL6AGrA5+dPaMY8=
golang.org/x/mod v0.15.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
golang.org/x/net v0.0.0-20190108225652-1e06a53dbb7e/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
@@ -81,8 +81,8 @@ golang.org/x/net v0.0.0-20200226121028-0de0cce0169b/go.mod h1:z5CRVTTTmAJ677TzLL
golang.org/x/net v0.0.0-20200822124328-c89045814202/go.mod h1:/O7V0waA8r7cgGh81Ro3o1hOxt32SMVPicZroKQ2sZA=
golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
golang.org/x/net v0.0.0-20211015210444-4f30a5c0130f/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
golang.org/x/net v0.18.0 h1:mIYleuAkSbHh0tCv7RvjL3F6ZVbLjq4+R7zbOn3Kokg=
golang.org/x/net v0.18.0/go.mod h1:/czyP5RqHAH4odGYxBJ1qz0+CE5WZ+2j1YgoEo8F2jQ=
golang.org/x/net v0.21.0 h1:AQyQV4dYCvJ7vGmJyKki9+PBdyvhkSd8EIx/qb0AYv4=
golang.org/x/net v0.21.0/go.mod h1:bIjVDfnllIU7BJ2DNgfnXvpSvtn8VRwhlsaeUTyUS44=
golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
@@ -92,8 +92,8 @@ golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJ
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.5.0 h1:60k92dhOjHxJkrqnwsfl8KuaHbn/5dl0lUPUklKo3qE=
golang.org/x/sync v0.5.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
golang.org/x/sync v0.6.0 h1:5BMeUDZ7vkXGfEr1x9B4bRcTH4lpkTkpdh0T/J+qjbQ=
golang.org/x/sync v0.6.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
golang.org/x/sys v0.0.0-20180830151530-49385e6e1522/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
@@ -102,8 +102,8 @@ golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f/go.mod h1:h1NjWce9XRLGQEsW7w
golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20211019181941-9d821ace8654/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.15.0 h1:h48lPFYpsTvQJZF4EKyI4aLHaev3CxivZmv7yZig9pc=
golang.org/x/sys v0.15.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
golang.org/x/sys v0.18.0 h1:DBdB3niSjOA/O0blCZBqDefyWNYveAYMNF1Wum0DYQ4=
golang.org/x/sys v0.18.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
@@ -120,8 +120,8 @@ golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtn
golang.org/x/tools v0.0.0-20200619180055-7c47624df98f/go.mod h1:EkVYQZoAsY45+roYkvgYkIh4xh/qjgUK9TdY2XT94GE=
golang.org/x/tools v0.0.0-20210106214847-113979e3529a/go.mod h1:emZCQorbCU4vsT4fOWvOPXz4eW1wZW4PmDk9uLelYpA=
golang.org/x/tools v0.1.8/go.mod h1:nABZi5QlRsZVlzPpHl034qft6wpY4eDcsTt5AaioBiU=
golang.org/x/tools v0.15.0 h1:zdAyfUGbYmuVokhzVmghFl2ZJh5QhcfebBgmVPFYA+8=
golang.org/x/tools v0.15.0/go.mod h1:hpksKq4dtpQWS1uQ61JkdqWM3LscIS6Slf+VVkm+wQk=
golang.org/x/tools v0.18.0 h1:k8NLag8AGHnn+PHbl7g43CtqZAwG60vZkLqgyZgIHgQ=
golang.org/x/tools v0.18.0/go.mod h1:GL7B4CwcLLeo59yx/9UWWuNOW1n3VZ4f5axWfML7Lcg=
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
86 changes: 50 additions & 36 deletions go/def.bzl
Original file line number Diff line number Diff line change
@@ -75,49 +75,63 @@ load(
)

_TOOLS_NOGO = [
"@org_golang_x_tools//go/analysis/passes/asmdecl:go_default_library",
"@org_golang_x_tools//go/analysis/passes/assign:go_default_library",
"@org_golang_x_tools//go/analysis/passes/atomic:go_default_library",
"@org_golang_x_tools//go/analysis/passes/atomicalign:go_default_library",
"@org_golang_x_tools//go/analysis/passes/bools:go_default_library",
"@org_golang_x_tools//go/analysis/passes/buildssa:go_default_library",
"@org_golang_x_tools//go/analysis/passes/buildtag:go_default_library",
# keep sorted
"appends",
"asmdecl",
"assign",
"atomic",
"atomicalign",
"bools",
"buildssa",
"buildtag",
# TODO(#2396): pass raw cgo sources to cgocall and re-enable.
# "@org_golang_x_tools//go/analysis/passes/cgocall:go_default_library",
"@org_golang_x_tools//go/analysis/passes/composite:go_default_library",
"@org_golang_x_tools//go/analysis/passes/copylock:go_default_library",
"@org_golang_x_tools//go/analysis/passes/ctrlflow:go_default_library",
"@org_golang_x_tools//go/analysis/passes/deepequalerrors:go_default_library",
"@org_golang_x_tools//go/analysis/passes/errorsas:go_default_library",
"@org_golang_x_tools//go/analysis/passes/findcall:go_default_library",
"@org_golang_x_tools//go/analysis/passes/httpresponse:go_default_library",
"@org_golang_x_tools//go/analysis/passes/ifaceassert:go_default_library",
"@org_golang_x_tools//go/analysis/passes/inspect:go_default_library",
"@org_golang_x_tools//go/analysis/passes/loopclosure:go_default_library",
"@org_golang_x_tools//go/analysis/passes/lostcancel:go_default_library",
"@org_golang_x_tools//go/analysis/passes/nilfunc:go_default_library",
"@org_golang_x_tools//go/analysis/passes/nilness:go_default_library",
"@org_golang_x_tools//go/analysis/passes/pkgfact:go_default_library",
"@org_golang_x_tools//go/analysis/passes/printf:go_default_library",
"@org_golang_x_tools//go/analysis/passes/shadow:go_default_library",
"@org_golang_x_tools//go/analysis/passes/shift:go_default_library",
"@org_golang_x_tools//go/analysis/passes/sortslice:go_default_library",
"@org_golang_x_tools//go/analysis/passes/stdmethods:go_default_library",
"@org_golang_x_tools//go/analysis/passes/stringintconv:go_default_library",
"@org_golang_x_tools//go/analysis/passes/structtag:go_default_library",
"@org_golang_x_tools//go/analysis/passes/testinggoroutine:go_default_library",
"@org_golang_x_tools//go/analysis/passes/tests:go_default_library",
"@org_golang_x_tools//go/analysis/passes/unmarshal:go_default_library",
"@org_golang_x_tools//go/analysis/passes/unreachable:go_default_library",
"@org_golang_x_tools//go/analysis/passes/unsafeptr:go_default_library",
"@org_golang_x_tools//go/analysis/passes/unusedresult:go_default_library",
# "cgocall",
"composite",
"copylock",
"ctrlflow",
"deepequalerrors",
"defers",
"directive",
"errorsas",
# Noisy and not actionable in some cases.
# "fieldalignment",
"findcall",
"framepointer",
"httpmux",
"httpresponse",
"ifaceassert",
"inspect",
"loopclosure",
"lostcancel",
"nilfunc",
"nilness",
"pkgfact",
"printf",
"reflectvaluecompare",
"shadow",
"shift",
"sigchanyzer",
"slog",
"sortslice",
"stdmethods",
"stringintconv",
"structtag",
"testinggoroutine",
"tests",
"timeformat",
"unmarshal",
"unreachable",
"unsafeptr",
"unusedresult",
"unusedwrite",
"usesgenerics",
]

# TOOLS_NOGO is a list of all analysis passes in
# golang.org/x/tools/go/analysis/passes.
# This is not backward compatible, so use caution when depending on this --
# new analyses may discover issues in existing builds.
TOOLS_NOGO = [str(Label(l)) for l in _TOOLS_NOGO]
TOOLS_NOGO = [str(Label("@org_golang_x_tools//go/analysis/passes/{}".format(p))) for p in _TOOLS_NOGO]

# Current version or next version to be tagged. Gazelle and other tools may
# check this to determine compatibility.
39 changes: 29 additions & 10 deletions go/private/repositories.bzl
Original file line number Diff line number Diff line change
@@ -65,13 +65,13 @@ def go_rules_dependencies(force = False):
wrapper(
http_archive,
name = "org_golang_x_tools",
# v0.15.0, latest as of 2023-11-16
# v0.18.0, latest as of 2024-03-26
urls = [
"https://mirror.bazel.build/github.com/golang/tools/archive/refs/tags/v0.15.0.zip",
"https://github.com/golang/tools/archive/refs/tags/v0.15.0.zip",
"https://mirror.bazel.build/github.com/golang/tools/archive/refs/tags/v0.18.0.zip",
"https://github.com/golang/tools/archive/refs/tags/v0.18.0.zip",
],
sha256 = "e76a03b11719138502c7fef44d5e1dc4469f8c2fcb2ee4a1d96fb09aaea13362",
strip_prefix = "tools-0.15.0",
sha256 = "5b79d9c1a66bd27fd5ba3db6b9f1e3e7dcc201df7d2a11281424129ac2db56ae",
strip_prefix = "tools-0.18.0",
patches = [
# deletegopls removes the gopls subdirectory. It contains a nested
# module with additional dependencies. It's not needed by rules_go.
@@ -106,20 +106,39 @@ def go_rules_dependencies(force = False):
wrapper(
http_archive,
name = "org_golang_x_sys",
# v0.15.0, latest as of 2023-12-15
# v0.18.0, latest as of 2024-03-26
urls = [
"https://mirror.bazel.build/github.com/golang/sys/archive/refs/tags/v0.15.0.zip",
"https://github.com/golang/sys/archive/refs/tags/v0.15.0.zip",
"https://mirror.bazel.build/github.com/golang/sys/archive/refs/tags/v0.18.0.zip",
"https://github.com/golang/sys/archive/refs/tags/v0.18.0.zip",
],
sha256 = "36e7b6587b60eabebcd5102211ef5fabc6c6f40d93dd0db83dcefd13cdeb1b71",
strip_prefix = "sys-0.15.0",
sha256 = "d5ffb367cf0b672a6b97e2e0cf775dbae36276986485cf665cef5fd677563651",
strip_prefix = "sys-0.18.0",
patches = [
# releaser:patch-cmd gazelle -repo_root . -go_prefix golang.org/x/sys -go_naming_convention import_alias
Label("//third_party:org_golang_x_sys-gazelle.patch"),
],
patch_args = ["-p1"],
)

# Needed by golang.org/x/tools
# releaser:upgrade-dep golang mod
wrapper(
http_archive,
name = "org_golang_x_mod",
# v0.16.0, latest as of 2024-03-26
urls = [
"https://mirror.bazel.build/github.com/golang/mod/archive/refs/tags/v0.16.0.zip",
"https://github.com/golang/mod/archive/refs/tags/v0.16.0.zip",
],
sha256 = "429f03a3eb0982540cc6b9bdfd1bc1e8dd07d43708a4e92aae6848b25316575e",
strip_prefix = "mod-0.16.0",
patches = [
# releaser:patch-cmd gazelle -repo_root . -go_prefix golang.org/x/mod -go_naming_convention import_alias
Label("//third_party:org_golang_x_mod-gazelle.patch"),
],
patch_args = ["-p1"],
)

# Needed by golang.org/x/tools/go/packages
# releaser:upgrade-dep golang xerrors
wrapper(
48 changes: 43 additions & 5 deletions go/private/rules/nogo.bzl
Original file line number Diff line number Diff line change
@@ -140,11 +140,49 @@ def nogo(name, visibility = None, **kwargs):
def nogo_wrapper(**kwargs):
if kwargs.get("vet"):
kwargs["deps"] = kwargs.get("deps", []) + [
Label("@org_golang_x_tools//go/analysis/passes/atomic:go_default_library"),
Label("@org_golang_x_tools//go/analysis/passes/bools:go_default_library"),
Label("@org_golang_x_tools//go/analysis/passes/buildtag:go_default_library"),
Label("@org_golang_x_tools//go/analysis/passes/nilfunc:go_default_library"),
Label("@org_golang_x_tools//go/analysis/passes/printf:go_default_library"),
Label("@org_golang_x_tools//go/analysis/passes/{}".format(p))
for p in [
# Taken from 'go tool vet help'.
# keep sorted
"appends",
sluongng marked this conversation as resolved.
Show resolved Hide resolved
"asmdecl",
"assign",
"atomic",
"bools",
"buildtag",
"cgocall",
# note that the 'go tool vet help' documented this
# with a plural name 'composites'.
# The actual package is singular.
"composite",
# note that the 'go tool vet help' documented this
# with a plural name 'copylocks'.
# The actual package is singular.
"copylock",
"defers",
"directive",
"errorsas",
"framepointer",
"httpresponse",
"ifaceassert",
"loopclosure",
"lostcancel",
"nilfunc",
"printf",
"shift",
"sigchanyzer",
"slog",
"stdmethods",
"stringintconv",
"structtag",
"testinggoroutine",
"tests",
"timeformat",
"unmarshal",
"unreachable",
"unsafeptr",
"unusedresult",
sluongng marked this conversation as resolved.
Show resolved Hide resolved
]
]
kwargs = {k: v for k, v in kwargs.items() if k != "vet"}
nogo(**kwargs)
32 changes: 23 additions & 9 deletions tests/integration/popular_repos/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -161,6 +161,7 @@ test_suite(
tests = [
"@org_golang_x_tools//benchmark/parse:parse_test",
"@org_golang_x_tools//cmd/benchcmp:benchcmp_test",
"@org_golang_x_tools//cmd/bisect:bisect_test",
"@org_golang_x_tools//cmd/digraph:digraph_test",
"@org_golang_x_tools//cmd/getgo:getgo_test",
"@org_golang_x_tools//cmd/go-contrib-init:go-contrib-init_test",
@@ -178,25 +179,32 @@ test_suite(
"@org_golang_x_tools//godoc/vfs:vfs_test",
"@org_golang_x_tools//godoc/vfs/gatefs:gatefs_test",
"@org_golang_x_tools//godoc/vfs/mapfs:mapfs_test",
"@org_golang_x_tools//internal/aliases:aliases_test",
"@org_golang_x_tools//internal/analysisinternal:analysisinternal_test",
"@org_golang_x_tools//internal/bisect:bisect_test",
"@org_golang_x_tools//internal/diff:diff_test",
"@org_golang_x_tools//internal/diff/lcs:lcs_test",
"@org_golang_x_tools//internal/diff/myers:myers_test",
"@org_golang_x_tools//internal/edit:edit_test",
"@org_golang_x_tools//internal/event:event_test",
"@org_golang_x_tools//internal/event/export:export_test",
"@org_golang_x_tools//internal/event/export/ocagent:ocagent_test",
"@org_golang_x_tools//internal/event/export/ocagent/wire:wire_test",
"@org_golang_x_tools//internal/event/keys:keys_test",
"@org_golang_x_tools//internal/event/label:label_test",
"@org_golang_x_tools//internal/fuzzy:fuzzy_test",
"@org_golang_x_tools//internal/gopathwalk:gopathwalk_test",
"@org_golang_x_tools//internal/jsonrpc2:jsonrpc2_test",
"@org_golang_x_tools//internal/jsonrpc2/servertest:servertest_test",
"@org_golang_x_tools//internal/jsonrpc2_v2:jsonrpc2_v2_test",
"@org_golang_x_tools//internal/memoize:memoize_test",
"@org_golang_x_tools//internal/persistent:persistent_test",
"@org_golang_x_tools//internal/pprof:pprof_test",
"@org_golang_x_tools//internal/proxydir:proxydir_test",
"@org_golang_x_tools//internal/robustio:robustio_test",
"@org_golang_x_tools//internal/stack:stack_test",
"@org_golang_x_tools//internal/tokeninternal:tokeninternal_test",
"@org_golang_x_tools//internal/typesinternal:typesinternal_test",
"@org_golang_x_tools//internal/versions:versions_test",
"@org_golang_x_tools//playground/socket:socket_test",
"@org_golang_x_tools//refactor/satisfy:satisfy_test",
"@org_golang_x_tools//txtar:txtar_test",
@@ -236,6 +244,7 @@ test_suite(
build_test(
name = "build_only",
targets = [
"@org_golang_x_crypto//nacl/secretbox:secretbox",
"@org_golang_x_crypto//ssh/agent:agent",
"@org_golang_x_crypto//ssh/test:test",
"@org_golang_x_crypto//ssh:ssh",
@@ -259,6 +268,7 @@ build_test(
"@org_golang_x_tools//cmd/callgraph:callgraph",
"@org_golang_x_tools//cmd/file2fuzz:file2fuzz",
"@org_golang_x_tools//cmd/fiximports:fiximports",
"@org_golang_x_tools//cmd/gonew:gonew",
"@org_golang_x_tools//cmd/gorename:gorename",
"@org_golang_x_tools//cmd/guru:guru",
"@org_golang_x_tools//cmd/signature-fuzzer/fuzz-driver:fuzz-driver",
@@ -268,10 +278,11 @@ build_test(
"@org_golang_x_tools//copyright:copyright",
"@org_golang_x_tools//go/analysis/analysistest:analysistest",
"@org_golang_x_tools//go/analysis/multichecker:multichecker",
"@org_golang_x_tools//go/analysis/passes/appends:appends",
"@org_golang_x_tools//go/analysis/passes/asmdecl:asmdecl",
"@org_golang_x_tools//go/analysis/passes/assign:assign",
"@org_golang_x_tools//go/analysis/passes/atomic:atomic",
"@org_golang_x_tools//go/analysis/passes/atomicalign:atomicalign",
"@org_golang_x_tools//go/analysis/passes/atomic:atomic",
"@org_golang_x_tools//go/analysis/passes/bools:bools",
"@org_golang_x_tools//go/analysis/passes/buildssa:buildssa",
"@org_golang_x_tools//go/analysis/passes/buildtag:buildtag",
@@ -280,11 +291,13 @@ build_test(
"@org_golang_x_tools//go/analysis/passes/copylock:copylock",
"@org_golang_x_tools//go/analysis/passes/ctrlflow:ctrlflow",
"@org_golang_x_tools//go/analysis/passes/deepequalerrors:deepequalerrors",
"@org_golang_x_tools//go/analysis/passes/defers:defers",
"@org_golang_x_tools//go/analysis/passes/directive:directive",
"@org_golang_x_tools//go/analysis/passes/errorsas:errorsas",
"@org_golang_x_tools//go/analysis/passes/fieldalignment:fieldalignment",
"@org_golang_x_tools//go/analysis/passes/findcall:findcall",
"@org_golang_x_tools//go/analysis/passes/framepointer:framepointer",
"@org_golang_x_tools//go/analysis/passes/httpmux:httpmux",
"@org_golang_x_tools//go/analysis/passes/httpresponse:httpresponse",
"@org_golang_x_tools//go/analysis/passes/ifaceassert:ifaceassert",
"@org_golang_x_tools//go/analysis/passes/loopclosure:loopclosure",
@@ -297,39 +310,40 @@ build_test(
"@org_golang_x_tools//go/analysis/passes/shadow:shadow",
"@org_golang_x_tools//go/analysis/passes/shift:shift",
"@org_golang_x_tools//go/analysis/passes/sigchanyzer:sigchanyzer",
"@org_golang_x_tools//go/analysis/passes/slog:slog",
"@org_golang_x_tools//go/analysis/passes/sortslice:sortslice",
"@org_golang_x_tools//go/analysis/passes/stdmethods:stdmethods",
"@org_golang_x_tools//go/analysis/passes/stringintconv:stringintconv",
"@org_golang_x_tools//go/analysis/passes/structtag:structtag",
"@org_golang_x_tools//go/analysis/passes/testinggoroutine:testinggoroutine",
"@org_golang_x_tools//go/analysis/passes/tests:tests",
"@org_golang_x_tools//go/analysis/passes/timeformat:timeformat",
"@org_golang_x_tools//go/analysis/passes/unmarshal:unmarshal",
"@org_golang_x_tools//go/analysis/passes/unreachable:unreachable",
"@org_golang_x_tools//go/analysis/passes/unsafeptr:unsafeptr",
"@org_golang_x_tools//go/analysis/passes/unusedresult:unusedresult",
"@org_golang_x_tools//go/analysis/passes/unusedwrite:unusedwrite",
"@org_golang_x_tools//go/analysis/passes/timeformat:timeformat",
"@org_golang_x_tools//go/analysis/passes/usesgenerics:usesgenerics",
"@org_golang_x_tools//go/analysis/unitchecker:unitchecker",
"@org_golang_x_tools//go/ast/inspector:inspector",
"@org_golang_x_tools//go/buildutil:buildutil",
"@org_golang_x_tools//go/callgraph/cha:cha",
"@org_golang_x_tools//go/callgraph/rta:rta",
"@org_golang_x_tools//go/callgraph/vta:vta",
"@org_golang_x_tools//godoc/static:static",
"@org_golang_x_tools//godoc/vfs/zipfs:zipfs",
"@org_golang_x_tools//go/expect:expect",
"@org_golang_x_tools//go/gccgoexportdata:gccgoexportdata",
"@org_golang_x_tools//go/gcexportdata:gcexportdata",
"@org_golang_x_tools//go/loader:loader",
"@org_golang_x_tools//go/packages/packagestest/testdata:testdata",
"@org_golang_x_tools//go/packages/packagestest:packagestest",
"@org_golang_x_tools//go/packages:packages",
"@org_golang_x_tools//go/packages/packagestest:packagestest",
"@org_golang_x_tools//go/packages/packagestest/testdata:testdata",
"@org_golang_x_tools//go/ssa/interp:interp",
"@org_golang_x_tools//go/ssa/ssautil:ssautil",
"@org_golang_x_tools//go/ssa:ssa",
"@org_golang_x_tools//go/types/typeutil:typeutil",
"@org_golang_x_tools//go/ssa/ssautil:ssautil",
"@org_golang_x_tools//go/types/objectpath:objectpath",
"@org_golang_x_tools//godoc/static:static",
"@org_golang_x_tools//godoc/vfs/zipfs:zipfs",
"@org_golang_x_tools//go/types/typeutil:typeutil",
"@org_golang_x_tools//refactor/eg:eg",
"@org_golang_x_tools//refactor/importgraph:importgraph",
"@org_golang_x_tools//refactor/rename:rename",
14 changes: 11 additions & 3 deletions tests/integration/popular_repos/README.rst
Original file line number Diff line number Diff line change
@@ -157,6 +157,7 @@ This runs tests from the repository `golang.org/x/tools <https://golang.org/x/to

* @org_golang_x_tools//benchmark/parse:parse_test
* @org_golang_x_tools//cmd/benchcmp:benchcmp_test
* @org_golang_x_tools//cmd/bisect:bisect_test
* @org_golang_x_tools//cmd/digraph:digraph_test
* @org_golang_x_tools//cmd/getgo:getgo_test
* @org_golang_x_tools//cmd/go-contrib-init:go-contrib-init_test
@@ -170,31 +171,36 @@ This runs tests from the repository `golang.org/x/tools <https://golang.org/x/to
* @org_golang_x_tools//go/callgraph/static:static_test
* @org_golang_x_tools//go/callgraph/vta/internal/trie:trie_test
* @org_golang_x_tools//go/cfg:cfg_test
* @org_golang_x_tools//go/vcs:vcs_test
* @org_golang_x_tools//godoc/redirect:redirect_test
* @org_golang_x_tools//godoc/vfs:vfs_test
* @org_golang_x_tools//godoc/vfs/gatefs:gatefs_test
* @org_golang_x_tools//godoc/vfs/mapfs:mapfs_test
* @org_golang_x_tools//internal/bug:bug_test
* @org_golang_x_tools//internal/aliases:aliases_test
* @org_golang_x_tools//internal/analysisinternal:analysisinternal_test
* @org_golang_x_tools//internal/bisect:bisect_test
* @org_golang_x_tools//internal/diff:diff_test
* @org_golang_x_tools//internal/diff/lcs:lcs_test
* @org_golang_x_tools//internal/diff/myers:myers_test
* @org_golang_x_tools//internal/edit:edit_test
* @org_golang_x_tools//internal/event:event_test
* @org_golang_x_tools//internal/event/export:export_test
* @org_golang_x_tools//internal/event/export/ocagent:ocagent_test
* @org_golang_x_tools//internal/event/export/ocagent/wire:wire_test
* @org_golang_x_tools//internal/event/keys:keys_test
* @org_golang_x_tools//internal/event/label:label_test
* @org_golang_x_tools//internal/fuzzy:fuzzy_test
* @org_golang_x_tools//internal/gopathwalk:gopathwalk_test
* @org_golang_x_tools//internal/jsonrpc2:jsonrpc2_test
* @org_golang_x_tools//internal/jsonrpc2/servertest:servertest_test
* @org_golang_x_tools//internal/jsonrpc2_v2:jsonrpc2_v2_test
* @org_golang_x_tools//internal/memoize:memoize_test
* @org_golang_x_tools//internal/persistent:persistent_test
* @org_golang_x_tools//internal/pprof:pprof_test
* @org_golang_x_tools//internal/proxydir:proxydir_test
* @org_golang_x_tools//internal/robustio:robustio_test
* @org_golang_x_tools//internal/stack:stack_test
* @org_golang_x_tools//internal/tokeninternal:tokeninternal_test
* @org_golang_x_tools//internal/typesinternal:typesinternal_test
* @org_golang_x_tools//internal/versions:versions_test
* @org_golang_x_tools//playground/socket:socket_test
* @org_golang_x_tools//refactor/satisfy:satisfy_test
* @org_golang_x_tools//txtar:txtar_test
@@ -231,3 +237,5 @@ This runs tests from the repository `golang.org/x/mod <https://golang.org/x/mod>
* @org_golang_x_mod//sumdb/dirhash:dirhash_test
* @org_golang_x_mod//sumdb/note:note_test
* @org_golang_x_mod//sumdb/storage:storage_test


4 changes: 2 additions & 2 deletions tests/integration/popular_repos/popular_repos.bzl
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ def popular_repos():
go_repository,
name = "org_golang_x_sys",
importpath = "golang.org/x/sys",
commit = "390168757d9c647283340d526204e3409d5903f3",
commit = "360f961f8978a4c9a7c2e849bb482780cd6bb553",
)
_maybe(
go_repository,
@@ -51,7 +51,7 @@ def popular_repos():
go_repository,
name = "org_golang_x_tools",
importpath = "golang.org/x/tools",
commit = "fe37c9e135b934191089b245ac29325091462508",
commit = "c5643e9baf7fed6936d70e3abf925f86fa895ca1",
)
_maybe(
go_repository,
38 changes: 24 additions & 14 deletions tests/integration/popular_repos/popular_repos.py
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@
dict(
name = "org_golang_x_sys",
importpath = "golang.org/x/sys",
commit = "390168757d9c647283340d526204e3409d5903f3",
commit = "360f961f8978a4c9a7c2e849bb482780cd6bb553",
excludes = [
"unix:unix_test", # TestOpenByHandleAt reads source file.
"windows:windows_test", # Needs testdata directory
@@ -78,18 +78,20 @@
dict(
name = "org_golang_x_tools",
importpath = "golang.org/x/tools",
commit = "fe37c9e135b934191089b245ac29325091462508",
commit = "c5643e9baf7fed6936d70e3abf925f86fa895ca1",
excludes = [
"blog:blog_test", # Needs goldmark
"cmd/bundle:bundle_test", # Needs testdata directory
"cmd/callgraph/testdata/src/pkg:pkg_test", # is testdata
"cmd/callgraph:callgraph_test", # Needs testdata directory
"cmd/callgraph/testdata/src/pkg:pkg_test", # is testdata
"cmd/deadcode:deadcode_test",
"cmd/file2fuzz:file2fuzz_test", # Requires working GOROOT, uses go build
"cmd/fiximports:fiximports_test", # requires working GOROOT, not present in CI.
"cmd/godoc:godoc_test", # TODO(#417)
"cmd/gonew:gonew_test", # Requires GOPATH or GOMODCACHE
"cmd/gorename:gorename_test", # TODO(#417)
"cmd/guru/testdata/src/referrers:referrers_test", # Not a real test
"cmd/guru:guru_test", # Needs testdata directory
"cmd/guru/testdata/src/referrers:referrers_test", # Not a real test
"cmd/signature-fuzzer/fuzz-driver:fuzz-driver_test", # requires working GOROOT
"cmd/signature-fuzzer/fuzz-runner:fuzz-runner_test", # requires working GOROOT
"cmd/signature-fuzzer/internal/fuzz-generator:fuzz-generator_test", # requires working GOROOT
@@ -99,11 +101,13 @@
"go/analysis/analysistest:analysistest_test", # requires build cache
"go/analysis/internal/analysisflags:analysisflags_test", # calls os.Exit(0) in a test
"go/analysis/internal/checker:checker_test", # loads test package with go/packages, which probably needs go list
"go/analysis/internal/versiontest:versiontest_test", # requires working GOROOT
"go/analysis/multichecker:multichecker_test", # requires go vet
"go/analysis/passes/appends:appends_test", # requires working GOROOT
"go/analysis/passes/asmdecl:asmdecl_test", # Needs testdata directory
"go/analysis/passes/assign:assign_test", # Needs testdata directory
"go/analysis/passes/atomic:atomic_test", # Needs testdata directory
"go/analysis/passes/atomicalign:atomicalign_test", # requires go list
"go/analysis/passes/atomic:atomic_test", # Needs testdata directory
"go/analysis/passes/bools:bools_test", # Needs testdata directory
"go/analysis/passes/buildssa:buildssa_test", # Needs testdata directory
"go/analysis/passes/buildtag:buildtag_test", # Needs testdata directory
@@ -113,11 +117,13 @@
"go/analysis/passes/copylock:copylock_test", # Needs testdata directory
"go/analysis/passes/ctrlflow:ctrlflow_test", # Needs testdata directory
"go/analysis/passes/deepequalerrors:deepequalerrors_test", # requires go list
"go/analysis/passes/defers:defers_test", # requires working GOROOT
"go/analysis/passes/directive:directive_test", # Needs GOROOT
"go/analysis/passes/errorsas:errorsas_test", # requires go list and testdata
"go/analysis/passes/fieldalignment:fieldalignment_test", # Needs GOROOT
"go/analysis/passes/findcall:findcall_test", # requires build cache
"go/analysis/passes/framepointer:framepointer_test", # Needs GOROOT
"go/analysis/passes/httpmux:httpmux_test", # Needs GOROOT
"go/analysis/passes/httpresponse:httpresponse_test", # Needs testdata directory
"go/analysis/passes/ifaceassert:ifaceassert_test", # Needs GOROOT
"go/analysis/passes/loopclosure:loopclosure_test", # Needs testdata directory
@@ -130,6 +136,7 @@
"go/analysis/passes/shadow:shadow_test", # Needs testdata directory
"go/analysis/passes/shift:shift_test", # Needs testdata director
"go/analysis/passes/sigchanyzer:sigchanyzer_test", # Needs testdata directory
"go/analysis/passes/slog:slog_test", # Needs GOROOT
"go/analysis/passes/sortslice:sortslice_test", # Needs 'go list'
"go/analysis/passes/stdmethods:stdmethods_test", # Needs testdata directory
"go/analysis/passes/stringintconv:stringintconv_test", # Needs 'go list'
@@ -140,50 +147,53 @@
"go/analysis/passes/tests/testdata/src/divergent:divergent_test", # Not a real test
"go/analysis/passes/tests/testdata/src/typeparams:typeparams_test", # Not a real test
"go/analysis/passes/tests:tests_test", # Needs testdata directory
"go/analysis/passes/timeformat:timeformat_test", # Needs go tool
"go/analysis/passes/unmarshal:unmarshal_test", # Needs go list
"go/analysis/passes/unreachable:unreachable_test", # Needs testdata directory
"go/analysis/passes/unsafeptr:unsafeptr_test", # Needs testdata directory
"go/analysis/passes/unusedresult:unusedresult_test", # Needs testdata directory
"go/analysis/passes/unusedwrite:unusedwrite_test", # Needs testdata directory
"go/analysis/passes/timeformat:timeformat_test", # Needs go tool
"go/analysis/passes/usesgenerics:usesgenerics_test", # Needs go tool
"go/analysis/unitchecker:unitchecker_test", # requires go vet
"go/ast/inspector:inspector_test", # requires GOROOT and GOPATH
"go/buildutil:buildutil_test", # Needs testdata directory
"go/callgraph/cha:cha_test", # Needs testdata directory
"go/callgraph/rta:rta_test", # Needs testdata directory
"go/callgraph/vta:vta_test", # Needs testdata directory
"godoc:godoc_test", # requires GOROOT and GOPATH
"godoc/static:static_test", # requires data files
"godoc/vfs/zipfs:zipfs_test", # requires GOROOT
"go/expect:expect_test", # Needs testdata directory
"go/gccgoexportdata:gccgoexportdata_test", # Needs testdata directory
"go/gcexportdata:gcexportdata_test", # Needs testdata directory
"go/internal/gccgoimporter:gccgoimporter_test", # Needs testdata directory
"go/loader:loader_test", # Needs testdata directory
"go/packages:packages_test", # Hah!
"go/packages/packagestest:packagestest_test", # requires build cache
"go/packages/packagestest/testdata/groups/two/primarymod/expect:expect_test", # Is testdata
"go/packages/packagestest/testdata:testdata_test", # Is testdata
"go/packages/packagestest:packagestest_test", # requires build cache
"go/packages:packages_test", # Hah!
"go/pointer:pointer_test", # Needs testdata directory
"go/ssa/interp:interp_test", # Needs testdata directory
"go/ssa/ssautil:ssautil_test", # Needs testdata directory
"go/ssa:ssa_test", # Needs testdata directory
"go/types/typeutil:typeutil_test", # requires GOROOT
"go/ssa/ssautil:ssautil_test", # Needs testdata directory
"go/types/objectpath:objectpath_test", # Incomaptible with Go SDK 1.18.3. Fixed in master but not yet released. TODO: fixme
"godoc/static:static_test", # requires data files
"godoc/vfs/zipfs:zipfs_test", # requires GOROOT
"godoc:godoc_test", # requires GOROOT and GOPATH
"go/types/typeutil:typeutil_test", # requires GOROOT
"internal/apidiff:apidiff_test", # Needs testdata directory
"internal/diff/difftest:difftest_test", # Needs diff tool
"internal/diffp:diffp_test", # Needs testdata directory
"internal/facts:facts_test", # loads test package with go/packages, which probably needs go list
"internal/gcimporter:gcimporter_test", # Needs testdata directory
"internal/gocommand:gocommand_test", # Needs go tool
"internal/imports:imports_test", # Needs testdata directory
"internal/refactor/inline/analyzer:analyzer_test",
"internal/refactor/inline:inline_test",
"internal/typeparams:typeparams_test", # Needs go tool
"present:present_test", # Needs goldmark
"refactor/eg:eg_test", # Needs testdata directory
"refactor/importgraph:importgraph_test", # TODO(#417)
"refactor/rename:rename_test", # TODO(#417)
],
build_excludes = [
"cmd/deadcode:deadcode",
"blog:blog", # requires present
"cmd/godoc:godoc", # requires godoc
"godoc:godoc", # requires goldmark
12 changes: 12 additions & 0 deletions third_party/bazel-gazelle.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/BUILD.bazel b/BUILD.bazel
index a57a1c3..0248e56 100644
--- a/BUILD.bazel
+++ b/BUILD.bazel
@@ -40,7 +40,6 @@ nogo(
name = "nogo",
vet = True,
visibility = ["//visibility:public"],
- deps = ["@org_golang_x_tools//go/analysis/passes/copylock"],
)

exports_files([
320 changes: 320 additions & 0 deletions third_party/org_golang_x_mod-gazelle.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,320 @@
diff -urN a/gosumcheck/BUILD.bazel b/gosumcheck/BUILD.bazel
--- a/gosumcheck/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/gosumcheck/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,15 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
+
+go_library(
+ name = "gosumcheck_lib",
+ srcs = ["main.go"],
+ importpath = "golang.org/x/mod/gosumcheck",
+ visibility = ["//visibility:private"],
+ deps = ["//sumdb"],
+)
+
+go_binary(
+ name = "gosumcheck",
+ embed = [":gosumcheck_lib"],
+ visibility = ["//visibility:public"],
+)
diff -urN a/internal/lazyregexp/BUILD.bazel b/internal/lazyregexp/BUILD.bazel
--- a/internal/lazyregexp/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/internal/lazyregexp/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,14 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+
+go_library(
+ name = "lazyregexp",
+ srcs = ["lazyre.go"],
+ importpath = "golang.org/x/mod/internal/lazyregexp",
+ visibility = ["//:__subpackages__"],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":lazyregexp",
+ visibility = ["//:__subpackages__"],
+)
diff -urN a/modfile/BUILD.bazel b/modfile/BUILD.bazel
--- a/modfile/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/modfile/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,36 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+ name = "modfile",
+ srcs = [
+ "print.go",
+ "read.go",
+ "rule.go",
+ "work.go",
+ ],
+ importpath = "golang.org/x/mod/modfile",
+ visibility = ["//visibility:public"],
+ deps = [
+ "//internal/lazyregexp",
+ "//module",
+ "//semver",
+ ],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":modfile",
+ visibility = ["//visibility:public"],
+)
+
+go_test(
+ name = "modfile_test",
+ srcs = [
+ "read_test.go",
+ "rule_test.go",
+ "work_test.go",
+ ],
+ data = glob(["testdata/**"]),
+ embed = [":modfile"],
+ deps = ["//module"],
+)
diff -urN a/module/BUILD.bazel b/module/BUILD.bazel
--- a/module/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/module/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,30 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+ name = "module",
+ srcs = [
+ "module.go",
+ "pseudo.go",
+ ],
+ importpath = "golang.org/x/mod/module",
+ visibility = ["//visibility:public"],
+ deps = [
+ "//internal/lazyregexp",
+ "//semver",
+ ],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":module",
+ visibility = ["//visibility:public"],
+)
+
+go_test(
+ name = "module_test",
+ srcs = [
+ "module_test.go",
+ "pseudo_test.go",
+ ],
+ embed = [":module"],
+)
diff -urN a/semver/BUILD.bazel b/semver/BUILD.bazel
--- a/semver/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/semver/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,20 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+ name = "semver",
+ srcs = ["semver.go"],
+ importpath = "golang.org/x/mod/semver",
+ visibility = ["//visibility:public"],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":semver",
+ visibility = ["//visibility:public"],
+)
+
+go_test(
+ name = "semver_test",
+ srcs = ["semver_test.go"],
+ embed = [":semver"],
+)
diff -urN a/sumdb/BUILD.bazel b/sumdb/BUILD.bazel
--- a/sumdb/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/sumdb/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,35 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+ name = "sumdb",
+ srcs = [
+ "cache.go",
+ "client.go",
+ "server.go",
+ "test.go",
+ ],
+ importpath = "golang.org/x/mod/sumdb",
+ visibility = ["//visibility:public"],
+ deps = [
+ "//internal/lazyregexp",
+ "//module",
+ "//sumdb/note",
+ "//sumdb/tlog",
+ ],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":sumdb",
+ visibility = ["//visibility:public"],
+)
+
+go_test(
+ name = "sumdb_test",
+ srcs = ["client_test.go"],
+ embed = [":sumdb"],
+ deps = [
+ "//sumdb/note",
+ "//sumdb/tlog",
+ ],
+)
diff -urN a/sumdb/dirhash/BUILD.bazel b/sumdb/dirhash/BUILD.bazel
--- a/sumdb/dirhash/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/sumdb/dirhash/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,20 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+ name = "dirhash",
+ srcs = ["hash.go"],
+ importpath = "golang.org/x/mod/sumdb/dirhash",
+ visibility = ["//visibility:public"],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":dirhash",
+ visibility = ["//visibility:public"],
+)
+
+go_test(
+ name = "dirhash_test",
+ srcs = ["hash_test.go"],
+ embed = [":dirhash"],
+)
diff -urN a/sumdb/note/BUILD.bazel b/sumdb/note/BUILD.bazel
--- a/sumdb/note/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/sumdb/note/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,23 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+ name = "note",
+ srcs = ["note.go"],
+ importpath = "golang.org/x/mod/sumdb/note",
+ visibility = ["//visibility:public"],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":note",
+ visibility = ["//visibility:public"],
+)
+
+go_test(
+ name = "note_test",
+ srcs = [
+ "example_test.go",
+ "note_test.go",
+ ],
+ embed = [":note"],
+)
diff -urN a/sumdb/storage/BUILD.bazel b/sumdb/storage/BUILD.bazel
--- a/sumdb/storage/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/sumdb/storage/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,24 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+ name = "storage",
+ srcs = [
+ "mem.go",
+ "storage.go",
+ "test.go",
+ ],
+ importpath = "golang.org/x/mod/sumdb/storage",
+ visibility = ["//visibility:public"],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":storage",
+ visibility = ["//visibility:public"],
+)
+
+go_test(
+ name = "storage_test",
+ srcs = ["mem_test.go"],
+ embed = [":storage"],
+)
diff -urN a/sumdb/tlog/BUILD.bazel b/sumdb/tlog/BUILD.bazel
--- a/sumdb/tlog/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/sumdb/tlog/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,29 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+ name = "tlog",
+ srcs = [
+ "note.go",
+ "tile.go",
+ "tlog.go",
+ ],
+ importpath = "golang.org/x/mod/sumdb/tlog",
+ visibility = ["//visibility:public"],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":tlog",
+ visibility = ["//visibility:public"],
+)
+
+go_test(
+ name = "tlog_test",
+ srcs = [
+ "ct_test.go",
+ "note_test.go",
+ "tile_test.go",
+ "tlog_test.go",
+ ],
+ embed = [":tlog"],
+)
diff -urN a/zip/BUILD.bazel b/zip/BUILD.bazel
--- a/zip/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/zip/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,30 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
+ name = "zip",
+ srcs = ["zip.go"],
+ importpath = "golang.org/x/mod/zip",
+ visibility = ["//visibility:public"],
+ deps = ["//module"],
+)
+
+alias(
+ name = "go_default_library",
+ actual = ":zip",
+ visibility = ["//visibility:public"],
+)
+
+go_test(
+ name = "zip_test",
+ srcs = [
+ "vendor_test.go",
+ "zip_test.go",
+ ],
+ data = glob(["testdata/**"]),
+ embed = [":zip"],
+ deps = [
+ "//module",
+ "//sumdb/dirhash",
+ "@org_golang_x_tools//txtar:go_default_library",
+ ],
+)
29 changes: 15 additions & 14 deletions third_party/org_golang_x_sys-gazelle.patch
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff -urN a/cpu/BUILD.bazel b/cpu/BUILD.bazel
--- a/cpu/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/cpu/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/cpu/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,68 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
@@ -71,7 +71,7 @@ diff -urN a/cpu/BUILD.bazel b/cpu/BUILD.bazel
+ embed = [":cpu"],
+)
diff -urN a/execabs/BUILD.bazel b/execabs/BUILD.bazel
--- a/execabs/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/execabs/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/execabs/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,24 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
@@ -99,7 +99,7 @@ diff -urN a/execabs/BUILD.bazel b/execabs/BUILD.bazel
+ embed = [":execabs"],
+)
diff -urN a/plan9/BUILD.bazel b/plan9/BUILD.bazel
--- a/plan9/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/plan9/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/plan9/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,45 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
@@ -148,7 +148,7 @@ diff -urN a/plan9/BUILD.bazel b/plan9/BUILD.bazel
+ }),
+)
diff -urN a/unix/BUILD.bazel b/unix/BUILD.bazel
--- a/unix/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/unix/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/unix/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,301 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
@@ -453,7 +453,7 @@ diff -urN a/unix/BUILD.bazel b/unix/BUILD.bazel
+ embed = [":unix"],
+)
diff -urN a/unix/internal/mkmerge/BUILD.bazel b/unix/internal/mkmerge/BUILD.bazel
--- a/unix/internal/mkmerge/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/unix/internal/mkmerge/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/unix/internal/mkmerge/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,20 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test")
@@ -477,9 +477,9 @@ diff -urN a/unix/internal/mkmerge/BUILD.bazel b/unix/internal/mkmerge/BUILD.baze
+ embed = [":mkmerge_lib"],
+)
diff -urN a/windows/BUILD.bazel b/windows/BUILD.bazel
--- a/windows/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/windows/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/windows/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,53 @@
@@ -0,0 +1,54 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+
+go_library(
@@ -522,6 +522,7 @@ diff -urN a/windows/BUILD.bazel b/windows/BUILD.bazel
+go_test(
+ name = "windows_test",
+ srcs = [
+ "env_windows_test.go",
+ "syscall_test.go",
+ "syscall_windows_test.go",
+ ],
@@ -534,7 +535,7 @@ diff -urN a/windows/BUILD.bazel b/windows/BUILD.bazel
+ }),
+)
diff -urN a/windows/mkwinsyscall/BUILD.bazel b/windows/mkwinsyscall/BUILD.bazel
--- a/windows/mkwinsyscall/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/windows/mkwinsyscall/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/windows/mkwinsyscall/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,20 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test")
@@ -558,7 +559,7 @@ diff -urN a/windows/mkwinsyscall/BUILD.bazel b/windows/mkwinsyscall/BUILD.bazel
+ embed = [":mkwinsyscall_lib"],
+)
diff -urN a/windows/registry/BUILD.bazel b/windows/registry/BUILD.bazel
--- a/windows/registry/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/windows/registry/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/windows/registry/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,34 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
@@ -596,7 +597,7 @@ diff -urN a/windows/registry/BUILD.bazel b/windows/registry/BUILD.bazel
+ embed = [":registry"],
+)
diff -urN a/windows/svc/BUILD.bazel b/windows/svc/BUILD.bazel
--- a/windows/svc/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/windows/svc/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/windows/svc/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,35 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
@@ -635,7 +636,7 @@ diff -urN a/windows/svc/BUILD.bazel b/windows/svc/BUILD.bazel
+ }),
+)
diff -urN a/windows/svc/debug/BUILD.bazel b/windows/svc/debug/BUILD.bazel
--- a/windows/svc/debug/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/windows/svc/debug/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/windows/svc/debug/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,23 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
@@ -662,7 +663,7 @@ diff -urN a/windows/svc/debug/BUILD.bazel b/windows/svc/debug/BUILD.bazel
+ visibility = ["//visibility:public"],
+)
diff -urN a/windows/svc/eventlog/BUILD.bazel b/windows/svc/eventlog/BUILD.bazel
--- a/windows/svc/eventlog/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/windows/svc/eventlog/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/windows/svc/eventlog/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,35 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
@@ -701,7 +702,7 @@ diff -urN a/windows/svc/eventlog/BUILD.bazel b/windows/svc/eventlog/BUILD.bazel
+ }),
+)
diff -urN a/windows/svc/example/BUILD.bazel b/windows/svc/example/BUILD.bazel
--- a/windows/svc/example/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/windows/svc/example/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/windows/svc/example/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,29 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
@@ -734,7 +735,7 @@ diff -urN a/windows/svc/example/BUILD.bazel b/windows/svc/example/BUILD.bazel
+ visibility = ["//visibility:public"],
+)
diff -urN a/windows/svc/mgr/BUILD.bazel b/windows/svc/mgr/BUILD.bazel
--- a/windows/svc/mgr/BUILD.bazel 1970-01-01 00:00:00.000000000 +0000
--- a/windows/svc/mgr/BUILD.bazel 1970-01-01 01:00:00.000000000 +0100
+++ b/windows/svc/mgr/BUILD.bazel 2000-01-01 00:00:00.000000000 -0000
@@ -0,0 +1,39 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
223,325 changes: 114,021 additions & 109,304 deletions third_party/org_golang_x_tools-deletegopls.patch

Large diffs are not rendered by default.

1,469 changes: 644 additions & 825 deletions third_party/org_golang_x_tools-gazelle.patch

Large diffs are not rendered by default.