Gazelle: add importpath attributes to rules #768
Merged
+82
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* go_prefix is no longer generated. In a future change, existing go_prefix rules will be removed in fix mode. * All go_library, go_test, and go_binary rules are generated with an importpath attribute. * importpath is now a mergeable attribute; Gazelle will replace existing importpath attributes unless they have a keep comment. This helps keep libraries up to date after they are moved to a new location. Related bazel-contrib#721
ianthehat
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go_prefix rules will be removed in fix mode.
importpath attribute.
existing importpath attributes unless they have a keep comment. This
helps keep libraries up to date after they are moved to a new
location.
Related #721