Gazelle: support empty prefixes #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gazelle now allows go_prefix to be empty. It must still be set either on the command line or in a go_prefix rule. When the prefix is empty, all imports not in the standard library are resolved locally. Dependencies will not point to the vendor directory or to external repositories. * Gazelle now hard-codes a list of standard packages from the SDK that was used to build it. * All imports (including standard imports) are now added to packages.GoTarget. The resolve package filters out standard libraries. Fixes bazel-contrib#870
ianthehat
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gazelle now allows go_prefix to be empty. It must still be set either
on the command line or in a go_prefix rule. When the prefix is empty,
all imports not in the standard library are resolved
locally. Dependencies will not point to the vendor directory or to
external repositories.
was used to build it.
packages.GoTarget. The resolve package filters out standard
libraries.
Fixes #870