Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gazelle to 0.32.0 #73

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Update Gazelle to 0.32.0 #73

merged 2 commits into from
Aug 30, 2023

Conversation

purkhusid
Copy link
Contributor

What?

Updates the bazel-gazelle package to the latest version

Why?

To get this changeset: bazel-contrib/bazel-gazelle#1508

@purkhusid
Update Gazell to 0.32.0
5b67cb0 
## What?
Updates the bazel-gazelle package to the latest version

## Why?
To get this changeset: bazel-contrib/bazel-gazelle#1508
@purkhusid purkhusid changed the title Update Gazell to 0.32.0 Update Gazelle to 0.32.0 Aug 28, 2023
illicitonion
illicitonion approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like upstream changed the label parsing slightly so that label:package no-longer parses. I think that's fine - if you remove line 91 from pkg/target_determinator_test.go, CI should go green

@purkhusid
Copy link
Contributor Author

Thanks! It looks like upstream changed the label parsing slightly so that label:package no-longer parses. I think that's fine - if you remove line 91 from pkg/target_determinator_test.go, CI should go green

Done!

@illicitonion illicitonion merged commit c3c8572 into bazel-contrib:main Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purkhusid @illicitonion