Support using configured rule inputs from 7.0.0 prereleases #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for more precise dependency analysis as we no longer need to guess configurations (where we over-estimate), and avoids potential deadlocks if we hit dependency cycles. Fixes bazel-contrib#72
illicitonion
force-pushed
the
configured-rule-inputs
branch
from
7d6e121
to
902281d
Compare
gibfahn
approved these changes
Aug 30, 2023
stevebarrau
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for more precise dependency analysis as we no longer need to guess configurations (where we over-estimate), and avoids potential deadlocks if we hit dependency cycles.
Fixes #72