Have -enforce-clean cause a failure when "before" location is unlcean #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make the error message less ambiguous, because "pre-checkout" and "post-checkout" may be misread to refer to "the before commit" and "the after commit" rather than "after checking out the before commit". * Add test which shows that if a file is consistently .gitignore'd before and after, it will continue to work.
|
This looks good to me - I made a PR to this PR with a few suggestions: michaelboyd2#1 - please take a look and merge it if you're happy, and I'll merge this one :) Thanks for taking the time! |
Review suggestions
|
Thanks very much, merged your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered a problem where a feature branch had a .gitignored file, but this was not in the main branch
.gitignore. Even when using-enforce-clean, this caused target determinator to identify all targets as changed in the workspace.This change is to make this situation cause a failure instead.
Closes #85