Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump tulsi, and use the same version in both locations #294

Merged
merged 2 commits into from
Jan 19, 2022
Merged

bump tulsi, and use the same version in both locations #294

merged 2 commits into from
Jan 19, 2022

Conversation

zachgrayio
Copy link
Collaborator

@zachgrayio zachgrayio commented Jan 18, 2022 •
edited
Loading

  • bump tulsi version
  • add variable PINTEREST_TULSI_COMMIT to reuse same commit across all uses of Tulsi, as the mismatch is the source of current errors from what I can tell

garrettmoon
garrettmoon approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zachgrayio zachgrayio merged commit 64c96b2 into bazel-xcode:master Jan 19, 2022
@zachgrayio zachgrayio deleted the bump_tulsi branch January 19, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachgrayio @garrettmoon