[email protected]

[malt3]

This supersedes #3143 and #3148:

• Prepare a new version of openssh
• Fix include of crypt.h (now with a minimally invasive config change)
• Package for macOS
  • The @openssh//:ssh and @openssh//:sshd targets were tested on Intel and Apple Silicon

[bazel-io]

Hello @mattyclarkson, modules you maintain (openssh) have been updated in this PR. Please review the changes.

[mattyclarkson]

LGTM, thanks!

[shixiong-jiang]

Hello @malt3,

One simple question plz.

My MODULE.bazel

bazel_dep(name = "openssh", version = "9.9p1")

single_version_override(
    module_name = "openssh",
    patch_strip = 1,
    patches = ["//patches:openssh.patch"],
    version = "9.9p1",
)

openssh.patch

+
+cc_library(
+    name = "ssherr",
+    hdrs = ["ssherr.h"],
+    visibility = ["//visibility:public"],
+)
+

My cc.

It works

#include "ssherr.h"

However, I prefer

#include "openssh/ssherr.h"

Filename ssherr.h (without parent folder) is very easy to conflict with another ssherr.h defined in other libraries.

Thx,

[malt3]

Hi @shixiong-jiang, I think this a question for @mattyclarkson, the maintainer.
This would require you to add include_prefix = "openssh" to cc_library targets in the OpenSSH module. This can probably be added as a configurable setting, but I‘m not the right person to ask about that.

[shixiong-jiang]

@malt3, Thx.

+
+cc_library(
+    name = "ssherr",
+    hdrs = ["ssherr.h"],
+    include_prefix = ["openssh"],
+    visibility = ["//visibility:public"],
+)
+

did work 👍