Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repository_ctx.download_and_extract should create necessary directories #1235

Closed
colinmarc opened this issue May 4, 2016 · 2 comments
Closed

repository_ctx.download_and_extract should create necessary directories #1235

colinmarc opened this issue May 4, 2016 · 2 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) type: bug
Milestone
0.4

Comments

@colinmarc
Copy link
Contributor

This is exactly the same as #1078. repository_ctx.download_and_extract doesn't create the destination dir, so you have to do something like:

ctx.file(ctx.path("empty"), "")
ctx.download_and_extract(...)
@damienmg damienmg added type: bug P2 We'll consider working on this in future. (Assignee optional) category: skylark remote repositories labels May 6, 2016
@damienmg damienmg added this to the 0.4 milestone May 6, 2016
@zaphar
Copy link
Contributor

zaphar commented May 7, 2016

This bug caused my no end of confusion while implementing mono as an external repository. Thanks for the workaround 👍

@zaphar zaphar mentioned this issue May 7, 2016
Merged
@damienmg
Copy link
Contributor

This is a duplicate of #1172

iainmerrick added a commit to iainmerrick/rules_dotnet that referenced this issue Nov 3, 2016
@iainmerrick
Remove workaround from repository_ctx.download_and_extract
88925dc 
bazelbuild/bazel#1235 is fixed now.
@iainmerrick iainmerrick mentioned this issue Nov 3, 2016
Merged
zaphar pushed a commit to bazel-contrib/rules_dotnet that referenced this issue Dec 2, 2016
@iainmerrick @zaphar
Remove workaround from repository_ctx.download_and_extract (#38)
b7e99ea 
bazelbuild/bazel#1235 is fixed now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 We'll consider working on this in future. (Assignee optional) type: bug
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
3 participants
@zaphar @colinmarc @damienmg