Create incompatible flags to remove pkg_deb and pkg_rpm #11219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schedule from pkg_tar. //tools/build_defs/pkg:incompatible_no_build_defs_pkg_deb //tools/build_defs/pkg:incompatible_no_build_defs_pkg_rpm The process of removing pkg_tar is blocked on switching from a dummy internal rules_python to the external rules_python, so that may not happen in time for the next incompatible flag flip release. Splitting removal of deb and rpm packaging rules out let's us flip that flag earlier.
jin
added
the
team-OSS
|
Ping |
aiuto
changed the title
|
friendly ping |
philwo
approved these changes
Sep 23, 2020
|
Don't see anything problematic with this, so from my side please go ahead. |
|
I don't think it will help. From looking at the CI scripts, I think this kind of flag will never be used. |
|
@aiuto Can we close this? |
|
Yes. I think the best path forward is to simply delete the code without a flag. The version in rules_pkg is still backwards compatible so people can easily migrate to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create incompatible flags to remove pkg_deb and pkg_rpm on a different schedule from pkg_tar.
//tools/build_defs/pkg:incompatible_no_build_defs_pkg_deb
//tools/build_defs/pkg:incompatible_no_build_defs_pkg_rpm
The process of removing pkg_tar is blocked on switching from a dummy internal rules_python to the external rules_python, so that may not happen in time for the next major Bazel release.
Splitting removal of deb and rpm packaging rules out let's us flip that flag earlier.
Track removal in #11217 and #11218