-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cherrypick request 4.2.0] Upgrade Android tools to 0.23 #13702
[Cherrypick request 4.2.0] Upgrade Android tools to 0.23 #13702
Conversation
*** Reason for rollback *** Downstream projects on bazelci have been updated to not hardcode the buildtools versions: #13409 (comment) *** Original change description *** Automated rollback of commit b6f87f1. *** Reason for rollback *** Breaks downstream bazel projects because AAPT2 needs to be updated in the build images: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2010#2595dff6-44ac-4996-9b38-cdacf2842215 *** Original change description *** Updates Android remote tools to 0.23.0 to include Update remote android tools to include c3edf13. RELNOTES: None. PiperOrigin-RevId: 377971964
Looks like the test failures are due to this:
|
Let me know if the new title is inaccurate. |
Thanks for pointing that out, yes I think there are some other changes that need to be added before this can be merged. I'll have to go find them since it's been a while since this was all submitted |
Title looks good |
I found the other change: 586de95 I'll try to merge them all into one change here. |
Please rebase onto the latest release-4.2.0-patches branch. |
Abandoning this pull request for a more convenient pull request: |
Cherrypick request for 4.2.0 (#13558).
This was originally 80feea0 and 586de95
This fixes merge conflicts from subsequent changes to the WORKSPACE file.
These change are to enable new features (androidx support in databinding) and fix bugs (e.g. c3edf13) in the android rules
*** Reason for rollback ***
Downstream projects on bazelci have been updated to not hardcode the buildtools versions: #13409 (comment)
*** Original change description ***
Automated rollback of commit b6f87f1.
*** Reason for rollback ***
Breaks downstream bazel projects because AAPT2 needs to be updated in the build images:
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2010#2595dff6-44ac-4996-9b38-cdacf2842215
*** Original change description ***
Updates Android remote tools to 0.23.0 to include Update remote android tools to include c3edf13.
RELNOTES: None.
PiperOrigin-RevId: 377971964