Do not merge BranchExp objects in place #13967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BranchExp forms a tree like structure that is used for evaluation of branches. By merging these in place when associating them to line numbers we alter the tree structure rooted at other line numbers, potentially resulting in false positives in the branch coverage report.
comius
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BranchExp objects form a tree structure that is used in report branch
evaluations for a source line. Merging of these objects in place when
associating them to line numbers will alter the structures rooted at
other line numbers, potentially resulting in false positives in the
branch coverage report.
Fixes #13962