-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirgate jar dependencies for testing to rules_jvm_external #17812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Mar 17, 2023
bazel/src/test/shell/testenv.sh.tmpl Lines 421 to 433 in a733c5e
Tests failing because we also use some jars in shell test setup. :( |
github-actions
bot
removed
awaiting-review
PR is awaiting review from an assigned reviewer
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
labels
Mar 22, 2023
aiuto
reviewed
Mar 22, 2023
aiuto
approved these changes
Mar 22, 2023
keertk
added
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Mar 22, 2023
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Remove checked-in jars used for `//src/test/java/...` and fetch them with rules_jvm_external instead. Working towards: bazelbuild#17036 Closes bazelbuild#17812. PiperOrigin-RevId: 518608132 Change-Id: I6a0d282febc27c538b5297054facc70a5a0ca35d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
PR is awaiting review from an assigned reviewer
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove checked-in jars used for
//src/test/java/...
and fetch them with rules_jvm_external instead.Working towards: #17036