Add ServerCapabilities into RemoteExecutionClient #18269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bazelbuild#18202, we discussed the possibility of conditionally using the new field exclusively based on the Remote Execution Server's capabilities. Capture Remote Execution Server's capabilities and store it in RemoteExecutor implementations for furture usage.
github-actions
bot
added
awaiting-review
sluongng
commented
Apr 29, 2023
Comment on lines
-201
to
+209
| /*executionInfo=*/ ImmutableMap.<String, String>of(), | ||
| /*runfilesSupplier=*/ null, | ||
| /*filesetMappings=*/ ImmutableMap.of(), | ||
| /*inputs=*/ NestedSetBuilder.create( | ||
| /* executionInfo= */ ImmutableMap.<String, String>of(), | ||
| /* runfilesSupplier= */ null, | ||
| /* filesetMappings= */ ImmutableMap.of(), | ||
| /* inputs= */ NestedSetBuilder.create( | ||
| Order.STABLE_ORDER, ActionInputHelper.fromPath("input")), | ||
| /*tools=*/ NestedSetBuilder.emptySet(Order.STABLE_ORDER), | ||
| /*outputs=*/ ImmutableSet.of( | ||
| /* tools= */ NestedSetBuilder.emptySet(Order.STABLE_ORDER), | ||
| /* outputs= */ ImmutableSet.of( |
There was a problem hiding this comment.
These hunks were added as a result of running
git diff --name-only | grep java$ | xargs google-java-format -i
Please let me know if I should remove them.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
Apr 29, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
Apr 29, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
May 1, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
May 1, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
coeuvre
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
May 15, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
May 15, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
May 15, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
May 15, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.3.0 |
bazel-io
removed
the
potential release blocker
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
May 17, 2023
In bazelbuild#18202, we discussed the possibility of conditionally using the new field exclusively based on the Remote Execution Server's capabilities. Capture Remote Execution Server's capabilities and store it in RemoteExecutor implementations for furture usage. Closes bazelbuild#18269. PiperOrigin-RevId: 531999688 Change-Id: I370869a45c804af1ec499b9c1654c6977c7ab7d0
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
In bazelbuild#18202, we discussed the possibility of conditionally using the new field exclusively based on the Remote Execution Server's capabilities. Capture Remote Execution Server's capabilities and store it in RemoteExecutor implementations for furture usage. Closes bazelbuild#18269. PiperOrigin-RevId: 531999688 Change-Id: I370869a45c804af1ec499b9c1654c6977c7ab7d0
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
May 30, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
May 30, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
This is a follow up to #18269, toward the discussion in #18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories. Closes #18270. PiperOrigin-RevId: 537817532 Change-Id: Ie299065a7c91abbfc7a4f181410f6a57471e7dc8
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
*** Reason for rollback *** Breaks remote server which only support REPI v2.0. *** Original change description *** Conditionally set output_paths based on Remote Executor capabilities This is a follow up to #18269, toward the discussion in #18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories. Closes #18270. PiperOrigin-RevId: 537883626 Change-Id: I13c03cb3f4d64f106dc90767a6e62dfbae4027e2
iancha1992
added a commit
that referenced
this pull request
Jun 6, 2023
In #18202, we discussed the possibility of conditionally using the new field exclusively based on the Remote Execution Server's capabilities. Capture Remote Execution Server's capabilities and store it in RemoteExecutor implementations for furture usage. Closes #18269. PiperOrigin-RevId: 531999688 Change-Id: I370869a45c804af1ec499b9c1654c6977c7ab7d0 Co-authored-by: Son Luong Ngoc <[email protected]>
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
Jun 13, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
Jun 20, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
Jun 21, 2023
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
Jul 22, 2024
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
Jul 22, 2024
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
sluongng
added a commit
to sluongng/bazel
that referenced
this pull request
Jul 24, 2024
This is a follow up to bazelbuild#18269, toward the discussion in bazelbuild#18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories.
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
This is a follow up to #18269, toward the discussion in #18202. Bump the Remote API supported version to v2.1. Based on the Capability of the Remote Executor, either use output_paths field or the legacy fields output_files and output_directories. Closes #18270. PiperOrigin-RevId: 675060530 Change-Id: If08975b48696e06da0da91898ba2dd4b1c6677d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18202, we discussed the possibility of conditionally using the new
field exclusively based on the Remote Execution Server's capabilities.
Capture Remote Execution Server's capabilities and store it in
RemoteExecutor implementations for furture usage.