Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that a credential helper can supply credentials for bzlmod. #18428

Closed
wants to merge 1 commit into from
Closed

Test that a credential helper can supply credentials for bzlmod. #18428

wants to merge 1 commit into from

Conversation

tjgq
Copy link
Contributor

@tjgq tjgq commented May 17, 2023

No description provided.

@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels May 17, 2023
meteorcloudy
meteorcloudy approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/test/py/bazel/bzlmod/bzlmod_credentials_test.py Outdated Show resolved Hide resolved
@tjgq tjgq force-pushed the credhelper-bzlmod branch from 1dd94a0 to aea1564 Compare May 17, 2023 13:45
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 17, 2023
@tjgq tjgq force-pushed the credhelper-bzlmod branch from aea1564 to b66a136 Compare May 17, 2023 14:04
@tjgq
Copy link
Contributor Author

tjgq commented May 17, 2023

Made a couple changes:

  • SimpleHTTPRequestHandler can only serve from the current working directory in Python <= 3.6 (which we're stuck with on CI). Fixed by monkey-patching.
  • The helper used in the test is a Python script, which can't be executed on Windows. I've just disabled the test, since there's little value in writing a separate version.

@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 18, 2023
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@tjgq @fweikert
Test that a credential helper can supply credentials for bzlmod.
35bba60 
Closes bazelbuild#18428.

PiperOrigin-RevId: 532793826
Change-Id: I0f63aa7ee341f5181b905c7ba78af60321b90836
@tjgq
Copy link
Contributor Author

tjgq commented Jun 12, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 12, 2023
@meteorcloudy
Copy link
Member

@bazel-io fork 6.3.0

@bazel-io bazel-io mentioned this pull request Jun 12, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 12, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 13, 2023
@tjgq @iancha1992
Test that a credential helper can supply credentials for bzlmod.
6b70d94 
Closes bazelbuild#18428.

PiperOrigin-RevId: 532793826
Change-Id: I0f63aa7ee341f5181b905c7ba78af60321b90836
@iancha1992 iancha1992 mentioned this pull request Jun 13, 2023
Merged
iancha1992 added a commit that referenced this pull request Jun 14, 2023
@iancha1992 @tjgq
Test that a credential helper can supply credentials for bzlmod. (#18663
eafdf2e 
)

Closes #18428.

PiperOrigin-RevId: 532793826
Change-Id: I0f63aa7ee341f5181b905c7ba78af60321b90836

Co-authored-by: Tiago Quelhas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjgq @meteorcloudy @bazel-io @sgowroji