Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path mapping test for multiplex sandboxing #21837

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Mar 27, 2024

Javac actions gained support for multiplex sandboxing with rules_java 7.5.0, which makes it possible to test path mapping in this mode.

Fixes #21091

Javac actions gained support for multiplex sandboxing with
rules_java 7.5.0, which makes it possible to test path mapping in this
mode.

Fixes bazelbuild#21091
@fmeum fmeum requested a review from aranguyen March 27, 2024 23:46
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Mar 27, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Mar 27, 2024

@aranguyen No new functionality in this PR, just additional verification of Java path mapping with yet another execution strategy.

@sgowroji sgowroji added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Mar 28, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 24, 2024

@aranguyen Friendly ping on this, it's just a new test.

@aranguyen aranguyen added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 26, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 26, 2024

@bazel-io fork 7.3.0

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 29, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jul 29, 2024
Javac actions gained support for multiplex sandboxing with rules_java 7.5.0, which makes it possible to test path mapping in this mode.

Fixes bazelbuild#21091

Closes bazelbuild#21837.

PiperOrigin-RevId: 657111790
Change-Id: Ib08f2c0bc48d210cce013e328da0e871f73278aa
@fmeum fmeum deleted the path-mapping-multiplex branch July 29, 2024 09:28
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2024
Javac actions gained support for multiplex sandboxing with rules_java
7.5.0, which makes it possible to test path mapping in this mode.

Fixes #21091

Closes #21837.

PiperOrigin-RevId: 657111790
Change-Id: Ib08f2c0bc48d210cce013e328da0e871f73278aa

Commit
8e79fe0

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiplex sandboxing support for Java actions
3 participants