Add new flag --incompatible_disable_native_repo_rules
#21913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyverald
requested review from
a team,
lberki,
meteorcloudy,
ahumesky and
ted-xie
as code owners
github-actions
bot
added
team-Configurability
Wyverald
force-pushed
the
wyv-nonative-flag
branch
from
a949407 to
834ac67
Compare
Wyverald
force-pushed
the
wyv-nonative-flag
branch
from
834ac67 to
2faca5c
Compare
fmeum
approved these changes
Apr 6, 2024
src/main/java/com/google/devtools/build/lib/rules/repository/LocalRepositoryFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/rules/repository/NewLocalRepositoryFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java
Outdated
Show resolved
Hide resolved
Wyverald
force-pushed
the
wyv-nonative-flag
branch
2 times, most recently
from
af1766a to
ab7bad2
Compare
Wyverald
changed the title
--enable_native_repo_rules--incompatible_disable_native_repo_rules
meteorcloudy
approved these changes
Apr 9, 2024
fmeum
approved these changes
Apr 9, 2024
Wyverald
force-pushed
the
wyv-nonative-flag
branch
from
ab7bad2 to
e189c49
Compare
Wyverald
added
awaiting-PR-merge
Wyverald
force-pushed
the
wyv-nonative-flag
branch
2 times, most recently
from
46b984a to
7958e88
Compare
This new flag defaults to `false`. When set to `true`, native repo rules cannot be used in WORKSPACE; their Starlark counterparts must be used. Native repo rules already can't be used in Bzlmod. Work towards #18285.
Wyverald
force-pushed
the
wyv-nonative-flag
branch
from
7958e88 to
000d1a0
Compare
Wyverald
added a commit
that referenced
this pull request
Apr 25, 2024
This new flag defaults to `false`. When set to `true`, native repo rules cannot be used in WORKSPACE; their Starlark counterparts must be used. Native repo rules already can't be used in Bzlmod. Work towards #18285. Closes #21913. PiperOrigin-RevId: 626410163 Change-Id: I4981cd8d99fc87d0d0b66991e563941478b40f12
sgowroji
removed
the
awaiting-PR-merge
Wyverald
added a commit
that referenced
this pull request
Apr 29, 2024
This new flag defaults to `false`. When set to `true`, native repo rules cannot be used in WORKSPACE; their Starlark counterparts must be used. Native repo rules already can't be used in Bzlmod. Work towards #18285. Closes #21913. PiperOrigin-RevId: 626410163 Change-Id: I4981cd8d99fc87d0d0b66991e563941478b40f12
Wyverald
added a commit
that referenced
this pull request
Apr 30, 2024
This new flag defaults to `false`. When set to `true`, native repo rules cannot be used in WORKSPACE; their Starlark counterparts must be used. Native repo rules already can't be used in Bzlmod. Work towards #18285. Closes #21913. PiperOrigin-RevId: 626410163 Change-Id: I4981cd8d99fc87d0d0b66991e563941478b40f12
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
This new flag defaults to `false`. When set to `true`, native repo rules cannot be used in WORKSPACE; their Starlark counterparts must be used. Native repo rules already can't be used in Bzlmod. Work towards bazelbuild#18285. Closes bazelbuild#21913. PiperOrigin-RevId: 626410163 Change-Id: I4981cd8d99fc87d0d0b66991e563941478b40f12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new flag defaults to
false. When set totrue, native repo rules cannot be used in WORKSPACE; their Starlark counterparts must be used. Native repo rules already can't be used in Bzlmod.Work towards #18285.