Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration hash to trace profile #23236

Closed
wants to merge 1 commit into from
Closed

Add configuration hash to trace profile #23236

wants to merge 1 commit into from

Conversation

AlessandroPatti
Copy link
Contributor

Similar to the target label and mnemonic, allow storing the configuration hash in the action trace data

@github-actions github-actions bot added team-Performance Issues for Performance teams awaiting-review PR is awaiting review from an assigned reviewer labels Aug 7, 2024
@AlessandroPatti AlessandroPatti changed the title Add configuration has to trace profile Add configuration hash to trace profile Aug 7, 2024
@tjgq
Copy link
Contributor

tjgq commented Aug 21, 2024

@coeuvre WDYT? In particular, is it worth it to put this behind a flag, or should we just do it unconditionally?

@AlessandroPatti
Copy link
Contributor Author

@coeuvre opinions? @tjgq I think one reason to have the flag is the file size: not all users are interested in the configuration (only useful if there's a significant enough use of transitions). Omitting it will save a few mb in large builds

tjgq
tjgq approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@tjgq tjgq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it behind a flag for now.

@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 6, 2024
@copybara-service copybara-service bot closed this in 29f7c86 Sep 6, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq tjgq approved these changes

Assignees
No one assigned
Labels
team-Performance Issues for Performance teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlessandroPatti @tjgq