[sandbox] Run sandbox from common execroot #8849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @laszlocsomor I have ported one integration test, will send it in another PR later. |
laszlocsomor
suggested changes
Jul 10, 2019
src/main/java/com/google/devtools/build/lib/sandbox/AbstractSandboxSpawnRunner.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/sandbox/DummySandboxedSpawn.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/sandbox/DummySandboxedSpawn.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/sandbox/DummySandboxedSpawn.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/sandbox/WindowsSandboxedSpawnRunner.java
Outdated
Show resolved
Hide resolved
|
I have added PR description, PTAL. |
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
Make sandboxed process run under main execroot instead of unique sandboxed execroot. This way, we do not need to copy/symlink input files before execution and clean up sandbox base after execution. Summary of how it works: - `windows-sandbox` blocks all file access under current directory (main execroot). - Declared input paths will be marked readable. - Declared output paths will be marked writable. - If sandboxed process tries to open file for read/write when the path is not marked with that permission, the operation will fail (e.g. `fopen` will return `nullptr`). Closes bazelbuild#8849. PiperOrigin-RevId: 257408096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sandboxed process run under main execroot instead of unique sandboxed execroot. This way, we do not need to copy/symlink input files before execution and clean up sandbox base after execution.
Summary of how it works:
windows-sandboxblocks all file access under current directory (main execroot).fopenwill returnnullptr).