Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Visual C++ 2022 by default #1770

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Use Visual C++ 2022 by default #1770

merged 1 commit into from
Nov 2, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Nov 2, 2023

No description provided.

@fmeum
Copy link
Contributor Author

fmeum commented Nov 2, 2023

Manual test passed in bazelbuild/bazel#19485

@meteorcloudy meteorcloudy merged commit cd29abd into bazelbuild:master Nov 2, 2023
1 check passed
@fmeum fmeum deleted the patch-1 branch November 2, 2023 12:44
@aiuto
Copy link
Contributor

aiuto commented Nov 6, 2023

Are all the CI machines updated? rules_pkg started to fail at head right after this.
https://buildkite.com/bazel/rules-pkg

@alexeagle
Copy link
Contributor

Hey @fmeum it seems like this broke projects like rules_pkg:
https://buildkite.com/bazel/rules-pkg/builds?branch=main



Visual C++ build tools seems to be installed at C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC
--
  | But Bazel can't find the following tools:
  | VCVARSALL.BAT, cl.exe, link.exe, lib.exe, ml64.exe

any recommendation what change we should make?

@fmeum
Copy link
Contributor Author

fmeum commented Nov 6, 2023

I don't see a difference in the presubmit.ymls, but the name of the task in rules_pkg includes VS 2019. @meteorcloudy Do you have an idea what needs updating here?

meteorcloudy added a commit that referenced this pull request Nov 7, 2023
@meteorcloudy
Update VS name to VS2022
92c993b 
#1770 is deployed
@meteorcloudy meteorcloudy mentioned this pull request Nov 7, 2023
Merged
@meteorcloudy
Copy link
Member

@fmeum That was just a hard coded name, updating in #1774

Let me take a look at the failure.

@meteorcloudy
Copy link
Member

I see, it's due to https://github.com/bazelbuild/rules_pkg/blob/3b095c64a65c03da78d756ba64632386af1fd10a/WORKSPACE#L86C22-L86C22

cc toolchain detection in rules_cc_toolchains must be out-dated and should not be used.

meteorcloudy added a commit to bazelbuild/rules_pkg that referenced this pull request Nov 7, 2023
@meteorcloudy
Don't load cc toolchain from rules_cc
84f5934 
The cc toolchain autoconfig is out of sync from Bazel and doesn't work with VS2022.

Related: bazelbuild/continuous-integration#1770
@meteorcloudy meteorcloudy mentioned this pull request Nov 7, 2023
Merged
@meteorcloudy
Copy link
Member

Sent bazelbuild/rules_pkg#779

meteorcloudy added a commit that referenced this pull request Nov 7, 2023
@meteorcloudy
Update VS name to VS2022 (#1774)
7dd25b5 
#1770 is
deployed
aiuto pushed a commit to bazelbuild/rules_pkg that referenced this pull request Nov 7, 2023
@meteorcloudy
Don't load cc toolchain from rules_cc (#779)
e97d155 
* Don't load cc toolchain from rules_cc

The cc toolchain autoconfig is out of sync from Bazel and doesn't work with VS2022.

Related: bazelbuild/continuous-integration#1770
* Fixes centos7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@fweikert fweikert Awaiting requested review from fweikert fweikert is a code owner

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmeum @aiuto @alexeagle @meteorcloudy