Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other modules(maven) in project view #6441

Closed
wants to merge 0 commits into from

Conversation

gchandu25
Copy link
Contributor

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

Maven modules are not visible in project view, along with bazel project.
Steps to reproduce:

  1. Import a bazel project (Ex: https://github.com/bazelbuild/examples/tree/main/java-tutorial).
  2. Add a maven project by using cmd + shift + a
  3. Sample maven project : https://github.com/spring-guides/gs-maven/tree/main/complete
  4. Maven module is visible from maven tool window but not under project view.

Screenshot 2024-05-20 at 3 53 42 PM

Copy link

google-cla bot commented May 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels May 20, 2024
* @param bazelParentVF parent Virtual file of bazel root node
* @return true if the tree node's root node is different from the bazel node
*/
private static boolean isOtherModule(AbstractTreeNode<?> node, VirtualFile bazelParentVF){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what other means here? can we have more descriptive name instead?

Copy link
Contributor Author

@gchandu25 gchandu25 May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Other' means any module other than those modules under the bazel workspace and didn't want to restrict to 'maven'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can name it accordingly: isOutsideContentRoot or so. other is too generic and your check is quite particular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure..I will update it with a better one.

@gchandu25 gchandu25 closed this Jun 7, 2024
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants