-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync select files #7127
base: master
Are you sure you want to change the base?
Sync select files #7127
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dbcd958
to
155c4c2
Compare
155c4c2
to
e1c0dce
Compare
@@ -183,7 +193,7 @@ public void afterQuerySync(Project project, BlazeContext context) { | |||
return; | |||
} | |||
if (requester.changePending.get()) { | |||
requester.requestSyncInternal(); | |||
requester.requestSyncInternal(ImmutableList.of()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work. Consider a sequence
- File 1 is added
- Sync Starts
- File 2 is added
- Sync Finishes
afterQuerySync
is called (this line)
File 2 won't be synced. The afterQuerySync
is supposed to be executed here nad catch File 2
e1c0dce
to
4199ef9
Compare
how about something lile that? #7168 |
Unfortunately I just noticed that the refresh logic is deeply tight with vcs ( Bazel -> Expand Sync To Working Set) and it is not enough to just use The problem is here, the
|
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>
Description of this change