Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOSP-pick] Do not wait for the write lock #7130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Dec 6, 2024

Cherry pick AOSP commit cff9f98e002cc7f7d7d379090f9dd4655221a278.

in BuildArtifactCacheDirectory as it may cause a deadlock if the
wait queue looks like "W", "R".. when the read lock is already held.

The first read lock stamp is released only after all reads are processed
and they won't until the write is processed but it can't proceed.

Bug: 373957467
Test: n/a
Change-Id: Ice28bae0288296fa8ed17c31187b578affb8d46c

AOSP: cff9f98e002cc7f7d7d379090f9dd4655221a278

in `BuildArtifactCacheDirectory` as it may cause a deadlock if the
wait queue looks like "W", "R".. when the read lock is already held.

The first read lock stamp is released only after all reads are processed
and they won't until the write is processed but it can't proceed.

Bug: 373957467
Test: n/a
Change-Id: Ice28bae0288296fa8ed17c31187b578affb8d46c

AOSP: cff9f98e002cc7f7d7d379090f9dd4655221a278
@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Dec 6, 2024
@sgowroji sgowroji added the product: Android Studio Android Studio plugin label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Awaiting review from Bazel team on PRs product: Android Studio Android Studio plugin
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

3 participants