Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add XML_OUTPUT_FILE envar to the non-macOS test runners #2596

Merged
merged 1 commit into from
Nov 18, 2024
Merged

add XML_OUTPUT_FILE envar to the non-macOS test runners #2596

merged 1 commit into from
Nov 18, 2024

Conversation

aaronsky
Copy link
Contributor

@aaronsky aaronsky commented Nov 13, 2024 •
edited
Loading

Simplifies the creation of in-process test observers that write to this path, and removes the need to add this var to every *_unit_test target.

@aaronsky aaronsky marked this pull request as ready for review November 13, 2024 15:27
@brentleyjones brentleyjones merged commit 1c9fc9c into bazelbuild:master Nov 18, 2024
8 checks passed
@aaronsky aaronsky deleted the aaronsky/add-test-env-xml_output_file branch December 10, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronsky @brentleyjones