-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to load Starlark extension '@rules_python_internal//:rules_python_config.bzl' in bzlmod #1543
Comments
Can you provide repro instructions? Another user reported this on slack, but we weren't able to reproduce it and our tests are OK. The only theory we have is a WORKSPACE file interfering with MODULE.bazel. |
It turned out I had these lines in
Wheh I removed it, everything is fine |
github-merge-queue bot
pushed a commit
to sematic-ai/sematic
that referenced
this issue
Aug 26, 2024
Python 3.8 [reaches EOL in October](https://devguide.python.org/versions/). Meanwhile, python 3.11 and 3.12 have been released since we last updated our supported python versions. This PR adds support for 3.11 and 3.12, and changes the default bazel targets to use 3.9 instead of 3.8. Some things of note: - The bazel dependency for torchvision in python3.10 is no longer resolving (and doesn't resolve for 3.11 or 3.12 either). For now, this PR handles that by making all bazel targets depending on torch vision only get built/tested for 3.8 and 3.9 . Note that this does NOT mean the examples using torch vision will not be runnable in higher python versions outside the context of bazel. - recent `rules_python` introduce a [complex bazel workspace dependency issue](bazelbuild/rules_python#1543) so we can only have bazel targets for building and testing with interpreters up to python3.11. Note again that this is a limitation of what we can do *in bazel* and not a limitation of what interpreters the resulting wheel can be run with. Note that this does not change what version of python the server or default worker images run with (python3.9 for both). So this is essentially an sdk and local-server only change. Testing -------- - Ran all bazel tests - Used bazel CLI to start local server and run the MNIST example against it - built a wheel and ran the following tests on fresh virtual envs with python 3.9/3.10/3.11/3.12: (a) install from wheel (b) stop and start local server (c) run mnist example (d) view it in browser --------- Co-authored-by: Josh Bauer <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 bug report
Affected Rule
rules_python: 0.26.0
Is this a regression?
Yes, the previous version in which this bug was not present was: 0.25.0Description
Using `rules_python` in `bzlmod` causes the issue🔬 Minimal Reproduction
Run
bazel test
on anypy_test
target🔥 Exception or Error
🌍 Your Environment
Operating System:
Output of
bazel version
:Rules_python version:
Anything else relevant?
The text was updated successfully, but these errors were encountered: