Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CI tests to use Bazel 6 #1498

Closed
crt-31 opened this issue May 10, 2023 · 2 comments
Closed

Upgrade CI tests to use Bazel 6 #1498

crt-31 opened this issue May 10, 2023 · 2 comments

Comments

@crt-31
Copy link
Contributor

crt-31 commented May 10, 2023

Bazel has just released version 6.2.0, and has been on version 6 since Dec 2022.

The CI tests currently use version 5.3.1, but they should probably be modified to run some (or all?) of the tests using the latest LTS Bazel version which is 6.2.0.

Note, I ran the tests with 6.0.0 on my local box, and ran into couple issues... mainly that the return value of str(label) has changed (see bazelbuild/bazel#16196). This causes a few tests to fail... but should be straightforward to fix by not assuming output of str(label).
@liucijus
Copy link
Collaborator

We don't run current tests on 6.x.x because some test code is not compatible yet. I want to test a few fixes, and cut Rules Scala release, then I guess .bazelversion can be updated.

@crt-31
Copy link
Contributor Author

crt-31 commented May 12, 2023

OK, sounds good. I got all the tests working with 6.2.0 with a bunch of fixes... I'll post a PR once I get the CLA done.

@liucijus liucijus closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liucijus @crt-31