Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_unambiguous_label_stringification #16196

Closed
Wyverald opened this issue Aug 31, 2022 · 3 comments
Closed

incompatible_unambiguous_label_stringification #16196

Wyverald opened this issue Aug 31, 2022 · 3 comments
Labels
breaking-change-6.0 Incompatible flags to be flipped in Bazel 6.0 incompatible-change Incompatible/breaking change migration-ready Incompatible flag is ready for migration with Bazel rolling releases or Bazel@last_green

Comments

@Wyverald
Copy link
Member

To fix #15916, we'll be setting the flag --incompatible_unambiguous_label_stringification to true in Bazel 6.0. This means that labels in the main repo will have an @ prepended to them when stringified, i.e. str(Label("@//foo:bar")) will be "@//foo:bar", instead of "//foo:bar".

Note that if --enable_bzlmod is specified, then the string will contain an extra @ ("@@//foo:bar"), using the canonical label literal syntax (see https://docs.google.com/document/d/1N81qfCa8oskCk5LqTW-LNthy6EBrDot7bdUsjz6JFC4/edit?usp=sharing).
@Wyverald Wyverald added incompatible-change Incompatible/breaking change migration-ready Incompatible flag is ready for migration with Bazel rolling releases or Bazel@last_green labels Aug 31, 2022
@Wyverald
Copy link
Member Author

cc @meteorcloudy

Wyverald added a commit that referenced this issue Sep 2, 2022
@Wyverald
Turn on unambiguous label stringification by default
bf8ec1e 
Fixes #15916

Fixes #16196

PiperOrigin-RevId: 470939938
Change-Id: I38caf7879fb82c72e07ef11a96be20ade5ac5401
@Wyverald Wyverald mentioned this issue Sep 5, 2022
Merged
Wyverald added a commit to bazelbuild/rules_rust that referenced this issue Sep 6, 2022
@Wyverald
Fix crate_universe/private/srcs.bzl to work with repo mappings
ffbd35b 
Currently the list in the said file only works if the rules_rust repo is named exactly "rules_rust". This commit fixes it so that the list contains Label objects which would work regardless of what the repo is called.

Also fixes the generation script to allow leading '@'s in the label stringification result (see bazelbuild/bazel#16196).
Wyverald added a commit to bazelbuild/rules_rust that referenced this issue Sep 6, 2022
@Wyverald
Fix crate_universe/private/srcs.bzl to work with repo mappings
c25e31f 
Currently the list in the said file only works if the rules_rust repo is named exactly "rules_rust". This commit fixes it so that the list contains Label objects which would work regardless of what the repo is called.

Also fixes the generation script to allow leading '@'s in the label stringification result (see bazelbuild/bazel#16196).
Wyverald added a commit to bazelbuild/rules_rust that referenced this issue Sep 6, 2022
@Wyverald
Fix crate_universe/private/srcs.bzl to work with repo mappings
65b9cec 
Currently the list in the said file only works if the rules_rust repo is named exactly "rules_rust". This commit fixes it so that the list contains Label objects which would work regardless of what the repo is called.

Also fixes the generation script to allow leading '@'s in the label stringification result (see bazelbuild/bazel#16196).
@Wyverald Wyverald mentioned this issue Sep 6, 2022
Merged
Wyverald added a commit to bazel-contrib/rules_go that referenced this issue Sep 6, 2022
@Wyverald
Fix non_executable_test to work with @// labels
8171dbc 
Needed to flip bazelbuild/bazel#16196
@Wyverald Wyverald mentioned this issue Sep 6, 2022
Merged
fmeum pushed a commit to bazel-contrib/rules_go that referenced this issue Sep 6, 2022
@Wyverald
Fix non_executable_test to work with @// labels (#3281)
6192283 
Needed to flip bazelbuild/bazel#16196
@Wyverald Wyverald added the breaking-change-6.0 Incompatible flags to be flipped in Bazel 6.0 label Sep 6, 2022
Wyverald added a commit to bazelbuild/rules_scala that referenced this issue Sep 6, 2022
@Wyverald
Fix aspect test to recognize @// labels
6eb8984 
Needed to flip bazelbuild/bazel#16196
@Wyverald Wyverald mentioned this issue Sep 6, 2022
Merged
illicitonion pushed a commit to bazelbuild/rules_rust that referenced this issue Sep 6, 2022
@Wyverald
Fix crate_universe/private/srcs.bzl to work with repo mappings (#1540)
cb9ca1b 
Currently the list in the said file only works if the rules_rust repo is named exactly "rules_rust". This commit fixes it so that the list contains Label objects which would work regardless of what the repo is called.

Also fixes the generation script to allow leading '@'s in the label stringification result (see bazelbuild/bazel#16196).
Wyverald added a commit to bazelbuild/rules_scala that referenced this issue Sep 7, 2022
@Wyverald
Fix aspect test to recognize @// labels (#1417)
ae781e4 
Needed to flip bazelbuild/bazel#16196
Wyverald added a commit that referenced this issue Sep 8, 2022
@Wyverald
Turn on unambiguous label stringification by default
7de9000 
Fixes #15916

Fixes #16196

PiperOrigin-RevId: 470939938
Change-Id: I38caf7879fb82c72e07ef11a96be20ade5ac5401
@Wyverald Wyverald mentioned this issue Sep 8, 2022
Closed
Wyverald added a commit to bazelbuild/rules_scala that referenced this issue Sep 8, 2022
@Wyverald
Fix test_scala_proto_library to accept @-prefixed labels
47a3fd4 
Needed to flip bazelbuild/bazel#16196
@Wyverald Wyverald mentioned this issue Sep 8, 2022
Merged
Wyverald added a commit to bazelbuild/rules_scala that referenced this issue Sep 9, 2022
@Wyverald
Fix test_scala_proto_library to accept @-prefixed labels (#1418)
a40063e 
Needed to flip bazelbuild/bazel#16196
@Wyverald Wyverald mentioned this issue Sep 9, 2022
Merged
Wyverald added a commit to bazel-contrib/rules_nodejs that referenced this issue Sep 9, 2022
@Wyverald
Fix BAZEL_TARGET values for main-repo labels
18827de 
With bazelbuild/bazel#16196 flipped, labels in the main repo will have an extra '@' prepended when stringified. This breaks stuff like https://github.com/bazelbuild/rules_nodejs/blob/a461224651a2802a53a163bef23d6a3fe2597d4d/internal/runfiles/index.cjs#L72 . This commit fixes the issue by removing leading '@'s in main-repo labels before setting BAZEL_TARGET
@Wyverald Wyverald mentioned this issue Sep 9, 2022
Merged
12 tasks
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this issue Sep 9, 2022
@copybara-github
Future-proof intellij_info creation by stripping leading '@'s from ma…
bce03e5 
…in-repo labels

Both "@//foo:bar" and "//foo:bar" mean the same thing in the main repo, but the latter can be ambiguous in a non-main repo, so Bazel 6.0 is going to flip bazelbuild/bazel#16196 (i.e. produce "@//foo:bar" instead of "//foo:bar" when `str(label)` is called). This means that for certain intellij tests (such as those deriving from IntellijAspectTest) to keep working, we need to strip the leading '@'s from any such labels.

PiperOrigin-RevId: 472728591
@copybara-service copybara-service bot mentioned this issue Sep 9, 2022
Closed
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this issue Sep 9, 2022
@copybara-github
Future-proof intellij_info creation by stripping leading '@'s from ma…
32b0d85 
…in-repo labels

Both "@//foo:bar" and "//foo:bar" mean the same thing in the main repo, but the latter can be ambiguous in a non-main repo, so Bazel 6.0 is going to flip bazelbuild/bazel#16196 (i.e. produce "@//foo:bar" instead of "//foo:bar" when `str(label)` is called). This means that for certain intellij tests (such as those deriving from IntellijAspectTest) to keep working, we need to strip the leading '@'s from any such labels.

PiperOrigin-RevId: 472728591
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this issue Sep 9, 2022
@copybara-github
Future-proof intellij_info creation by stripping leading '@'s from ma…
41d1964 
…in-repo labels

Both "@//foo:bar" and "//foo:bar" mean the same thing in the main repo, but the latter can be ambiguous in a non-main repo, so Bazel 6.0 is going to flip bazelbuild/bazel#16196 (i.e. produce "@//foo:bar" instead of "//foo:bar" when `str(label)` is called). This means that for certain intellij tests (such as those deriving from IntellijAspectTest) to keep working, we need to strip the leading '@'s from any such labels.

PiperOrigin-RevId: 473258584
Wyverald pushed a commit to bazelbuild/intellij that referenced this issue Sep 9, 2022
@Wyverald
Future-proof intellij_info creation by stripping leading '@'s from ma…
b3fcfbb 
…in-repo labels

Both "@//foo:bar" and "//foo:bar" mean the same thing in the main repo, but the latter can be ambiguous in a non-main repo, so Bazel 6.0 is going to flip bazelbuild/bazel#16196 (i.e. produce "@//foo:bar" instead of "//foo:bar" when `str(label)` is called). This means that for certain intellij tests (such as those deriving from IntellijAspectTest) to keep working, we need to strip the leading '@'s from any such labels.

PiperOrigin-RevId: 473258584
@Wyverald Wyverald mentioned this issue Sep 9, 2022
Merged
3 tasks
mai93 pushed a commit to bazelbuild/intellij that referenced this issue Sep 9, 2022
@Wyverald
Future-proof intellij_info creation by stripping leading '@'s from ma…
0e1cc31 
…in-repo labels (#3913)

Both "@//foo:bar" and "//foo:bar" mean the same thing in the main repo, but the latter can be ambiguous in a non-main repo, so Bazel 6.0 is going to flip bazelbuild/bazel#16196 (i.e. produce "@//foo:bar" instead of "//foo:bar" when `str(label)` is called). This means that for certain intellij tests (such as those deriving from IntellijAspectTest) to keep working, we need to strip the leading '@'s from any such labels.
Wyverald added a commit to bazel-contrib/rules_nodejs that referenced this issue Sep 9, 2022
@Wyverald
Fix BAZEL_TARGET values for main-repo labels (#3547)
2c718f9 
With bazelbuild/bazel#16196 flipped, labels in the main repo will have an extra '@' prepended when stringified. This breaks stuff like https://github.com/bazelbuild/rules_nodejs/blob/a461224651a2802a53a163bef23d6a3fe2597d4d/internal/runfiles/index.cjs#L72 . This commit fixes the issue by removing leading '@'s in main-repo labels before setting BAZEL_TARGET
cpsauer pushed a commit to hedronvision/bazelbuild-intellij that referenced this issue Sep 9, 2022
@Wyverald @cpsauer
Future-proof intellij_info creation by stripping leading '@'s from ma…
3f424bc 
…in-repo labels (bazelbuild#3913)

Both "@//foo:bar" and "//foo:bar" mean the same thing in the main repo, but the latter can be ambiguous in a non-main repo, so Bazel 6.0 is going to flip bazelbuild/bazel#16196 (i.e. produce "@//foo:bar" instead of "//foo:bar" when `str(label)` is called). This means that for certain intellij tests (such as those deriving from IntellijAspectTest) to keep working, we need to strip the leading '@'s from any such labels.
This was referenced Sep 13, 2022
Open
Closed
Closed
Wyverald added a commit to bazelbuild/continuous-integration that referenced this issue Sep 15, 2022
@Wyverald
temporarily disable rules_scala
73964b1 
so that we can flip bazelbuild/bazel#16196
@Wyverald Wyverald mentioned this issue Sep 15, 2022
Merged
fweikert pushed a commit to bazelbuild/continuous-integration that referenced this issue Sep 15, 2022
@Wyverald
temporarily disable rules_scala (#1446)
79deb04 
so that we can flip bazelbuild/bazel#16196
aiuto pushed a commit to aiuto/bazel that referenced this issue Oct 12, 2022
@Wyverald @aiuto
Turn on unambiguous label stringification by default
f78892d 
Fixes bazelbuild#15916

Fixes bazelbuild#16196

PiperOrigin-RevId: 474520825
Change-Id: I38caf7879fb82c72e07ef11a96be20ade5ac5401
ittaiz pushed a commit to wix-playground/intellij that referenced this issue Oct 24, 2022
@Wyverald @ittaiz
Future-proof intellij_info creation by stripping leading '@'s from ma…
31360e4 
…in-repo labels (bazelbuild#3913)

Both "@//foo:bar" and "//foo:bar" mean the same thing in the main repo, but the latter can be ambiguous in a non-main repo, so Bazel 6.0 is going to flip bazelbuild/bazel#16196 (i.e. produce "@//foo:bar" instead of "//foo:bar" when `str(label)` is called). This means that for certain intellij tests (such as those deriving from IntellijAspectTest) to keep working, we need to strip the leading '@'s from any such labels.
@groodt groodt mentioned this issue Dec 21, 2022
Merged
12 tasks
@guw guw mentioned this issue Feb 28, 2023
Closed
@brentleyjones
Copy link
Contributor

@Wyverald Is 7.0 or 8.0 the right time to no-op this?

@Wyverald
Copy link
Member Author

Wyverald commented Apr 5, 2023

Unfortunately this is still used in Google (a monorepo where '@' is never used), so I don't think we could remove/no-op this anytime soon.

@crt-31 crt-31 mentioned this issue May 10, 2023
Closed
fmeum pushed a commit to fmeum/continuous-integration that referenced this issue Dec 10, 2023
@Wyverald @fmeum
temporarily disable rules_scala (bazelbuild#1446)
bbc3c48 
so that we can flip bazelbuild/bazel#16196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change-6.0 Incompatible flags to be flipped in Bazel 6.0 incompatible-change Incompatible/breaking change migration-ready Incompatible flag is ready for migration with Bazel rolling releases or Bazel@last_green
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brentleyjones @Wyverald