Fall back to native rules if possible #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides compatibility with Bazel versions before 7.4.0. Also requires adding `bazel_skylib` to the dependency macro.
comius
approved these changes
Oct 14, 2024
comius
reviewed
Oct 14, 2024
shell/private/sh_binary.bzl
Outdated
|
|
||
| load(":sh_executable.bzl", "make_sh_executable_rule") | ||
|
|
||
| visibility("//shell") |
There was a problem hiding this comment.
This will also limit doc generation in Bazel, because I need to point it to the actual rules.
|
@comius I added the |
Looks good. Thanks! |
comius
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides compatibility with Bazel versions before 7.4.0.
Also requires adding
bazel_skylibto the dependency macro.Fixes #9