Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTA and pop up modal are not consistent #92

Closed
6 tasks done
leihelondon opened this issue May 10, 2021 · 0 comments · Fixed by #95
Closed
6 tasks done

CTA and pop up modal are not consistent #92

leihelondon opened this issue May 10, 2021 · 0 comments · Fixed by #95
Assignees
@allishultes
Labels
UX improvements

Comments

@leihelondon
Copy link
Contributor

leihelondon commented May 10, 2021 •
edited by allishultes
Loading

Context:
When "New Programme Script" button is clicked, it shows the following modal, the content of which is not consistent with what the buttons says, e.g. "News Programme Script" vs "New Paper Edit":

Screen Shot 2021-05-10 at 21 48 18

This ticket is to:

  • Change "New Paper Edit" to "New Programme Script"
  • Change "Title" to "Programme Script Title"
  • Change "Enter a project title" to "Enter a programme script title"
  • Remove "Choose a title"
  • Change "Enter a project description" to "Enter a programme script description (optional)"
  • Remove "Choose an optional description"
@tamsingreen tamsingreen transferred this issue from bbc/digital-paper-edit-firebase May 10, 2021
@allishultes allishultes self-assigned this May 11, 2021
allishultes added a commit that referenced this issue May 11, 2021
@allishultes
refactor(modal): #92 Add different form values for projects and scripts
81208c5
@allishultes allishultes mentioned this issue May 11, 2021
Merged
3 tasks
@allishultes allishultes linked a pull request May 11, 2021 that will close this issue
refactor(modal): #92 Add different form values for projects and scripts #95
Merged
3 tasks
@allishultes allishultes mentioned this issue May 11, 2021
Merged
1 task
allishultes added a commit that referenced this issue May 12, 2021
@allishultes
refactor(form): #92 Add form group ids
cf1822b
allishultes added a commit that referenced this issue May 12, 2021
@allishultes
refactor(form): #92 Removes useEffect import
7f39178
allishultes added a commit that referenced this issue May 19, 2021
@allishultes
chore(transcripts): #92 Merge and fix edit / new bugs
53e0c38
allishultes added a commit that referenced this issue May 19, 2021
@allishultes
chore(merge): #92 Complete merge and remove console errors
153efd2
allishultes added a commit that referenced this issue May 21, 2021
@allishultes
chore(semver): #92 Update changelog and version number
a543f18
allishultes added a commit that referenced this issue May 21, 2021
@allishultes
refactor(modal): #92 Add different form values for projects and scrip…
e0eb31d 
…ts (#95)

* refactor(modal): #92 Add different form values for projects and scripts

* refactor(form): #92 Add form group ids

* refactor(form): #92 Removes useEffect import

* chore(merge): #92 Complete merge and remove console errors

* chore(transcripts): Remove cancelUpload button that is not working

* chore(semver): #92 Update changelog and version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allishultes allishultes

Labels
UX improvements
Projects
None yet
Milestone
No milestone
2 participants
@leihelondon @allishultes