Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaiFicSkillTableのcommand_patternがRuby依存にならないように #401

Merged
merged 2 commits into from
Mar 28, 2021

Conversation

ysakasin
Copy link
Member

@ysakasin ysakasin commented Mar 28, 2021

BCDice::Base#register_prefix にRegexpのインスタンスが渡されると、 BCDice::Base#command_pattern がJavaScript等で解釈できない応答になるため修正する。

register_prefix にRegexpが渡されると以下のようになってしまう。 (?-mix:RTT[1-6]?) の部分がJavaScriptでは解釈できない。

/^S?([+\-\dD(]+|\d+B\d+|C|choice|D66|(repeat|rep|x)\d+|\d+R\d+|\d+U\d+|BCDiceVersion|(?-mix:RTT[1-6]?)|RCT)/i

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #401 (1aa4901) into master (2ec6679) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1aa4901 differs from pull request most recent head 1eb03a9. Consider uploading reports for the commit 1eb03a9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files         283      283           
  Lines       18484    18484           
=======================================
  Hits        17571    17571           
  Misses        913      913           
Impacted Files Coverage Δ
lib/bcdice/common_command/add_dice.rb 100.00% <100.00%> (ø)
lib/bcdice/dice_table/sai_fic_skill_table.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec6679...1eb03a9. Read the comment docs.

@ysakasin ysakasin merged commit 9569e70 into master Mar 28, 2021
@ysakasin ysakasin deleted the fix-sai_fic_skill_table-prefix branch March 28, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant