[SwordWorld/SwordWorld2.0/SwordWorld2.5] Result対応 #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
=======================================
Coverage 95.14% 95.15%
=======================================
Files 286 286
Lines 18471 18485 +14
=======================================
+ Hits 17575 17589 +14
Misses 896 896
Continue to review full report at Codecov.
|
ysakasin
requested changes
Apr 21, 2021
Comment on lines
8
to
13
| NO_TARGET = 0 | ||
| SUCCESS = 1 | ||
| FAILURE = 2 | ||
| SUPER_SUCCESS = 3 | ||
| CRITICAL = 4 | ||
| FUMBLE = 5 |
There was a problem hiding this comment.
enum的な利用をする場合、IntegerではなくSymbolを定数の値としてください。
lib/bcdice/game_system/SwordWorld.rb
Outdated
| @@ -301,6 +309,7 @@ def rollDice(_command) | |||
| # @param rateResults [Array<String>] | |||
| # @param dice_total [Integer] | |||
| # @param round [Integer] | |||
| # @return [Array<String, Boolean>] output, critical, fumble | |||
There was a problem hiding this comment.
Suggested change
| # @return [Array<String, Boolean>] output, critical, fumble | |
| # @return [Array(String, Boolean, Boolean)] output, critical, fumble |
YARDではArrayをTupleのように使う場合このように書きます。
| def result_str(total_sum, n_value_groups, fumble, critical) | ||
| return "自動的失敗" if fumble | ||
| return "自動的成功" if critical | ||
| # @return [Integer] |
There was a problem hiding this comment.
Suggested change
| # @return [Integer] | |
| # @return [Symbol] |
|
そこまでせずとも |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#423 の SwordWorld/SwordWorld2.0/SwordWorld2.5 対応です。
威力表のクリファン対応および、2.0の超越判定の成功失敗/クリファン対応となります
通常の2d6は既に対応済みでした。