Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vampire:The Masquerade5thダイスボットのResult対応 #534

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

FredGreenfield
Copy link
Contributor

今回の修正

  • Resultを使用するように修正
    ゲームシステム固有コマンドのResult対応をする #423 の対応です。[Critical Win]はクリティカル扱い、[Bestial Failure]をファンブル扱いとしています。
    [Messy Critical]は悪い結果が発生するクリティカルですが、これもクリティカル扱いとしています。

  • テストケースを追加
    上記、[Messy Critical]の発生条件を十分にカバーできていなかったので追加しました。
    10,10でクリティカル、Hungerダイスの10が混ざると[Messy Critical]なので、Hungerダイス、通常ダイスにそれぞれ10が出たケースとHungerダイスのみ10,10が出たパターンを追加しています。

・テストケースを追加
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #534 (66dc5e8) into master (94c8f05) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   95.54%   95.54%   -0.01%     
==========================================
  Files         320      320              
  Lines       18749    18747       -2     
==========================================
- Hits        17913    17911       -2     
  Misses        836      836              
Impacted Files Coverage Δ
lib/bcdice/game_system/VampireTheMasquerade5th.rb 98.36% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c8f05...66dc5e8. Read the comment docs.

@FredGreenfield FredGreenfield changed the title Result対応 Vampire:The Masquerade5thダイスボットのResult対応 Feb 25, 2022
Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@ysakasin ysakasin merged commit d24c5ad into bcdice:master Feb 28, 2022
@FredGreenfield FredGreenfield deleted the vtm_5th branch February 28, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants