Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorgEternity]高揚(UP)コマンドに修正値指定が出来るように拡張 #580

Merged
merged 3 commits into from
Nov 12, 2022

Conversation

Faceless192x
Copy link
Contributor

UPコマンドをUP[m]形式で記述できるように拡張しました。([m]は省略可)
現状のテストで、mの所に数式が入ると空文字列を返すように書かれていた為、数式には未対応としました。

@ysakasin ysakasin self-requested a review November 8, 2022 05:35
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@19fdb92). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #580   +/-   ##
=========================================
  Coverage          ?   95.39%           
=========================================
  Files             ?      323           
  Lines             ?    18229           
  Branches          ?     4726           
=========================================
  Hits              ?    17389           
  Misses            ?      840           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/bcdice/game_system/TorgEternity.rb 99.13% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ysakasin ysakasin added the 変更 動作の変更 label Nov 10, 2022
@Faceless192x
Copy link
Contributor Author

ヘルプメッセージに「[m]が省略可能」である旨、記載しました。

@ysakasin ysakasin merged commit caa974d into bcdice:master Nov 12, 2022
@ysakasin
Copy link
Member

@Faceless192x ありがとうございます! マージしました。

@Faceless192x Faceless192x deleted the feature/TorgEternity branch November 12, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
変更 動作の変更
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants