-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ダンジョンズ&ドラゴンス第5版、武器の両手持ちのダメージに対応 #612
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
741ac00
D&D5thの戦闘ロール実装
Faceless192x 328023b
Merge branch 'master' of github.com:Faceless192x/BCDice
Faceless192x 5d1f299
Merge branch 'master' of github.com:Faceless192x/BCDice
Faceless192x f8dbef6
4Merge
Faceless192x ca85471
Merge branch 'master' of github.com:Faceless192x/BCDice
Faceless192x 155a9c3
武器の両手持ちダメージに対応するコマンドの実装
Faceless192x 1c7981e
HELPの書き漏れを修正
Faceless192x cfde88a
条件文がややっこしかったのを修正
Faceless192x f1300a7
攻撃ロール時にクリティカル値を指定できるようにした
Faceless192x 232e67d
HELPの追加忘れを修正
Faceless192x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
記述ミスかと思いますので修正お願いします
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if じゃなくて unless を使った方が良いということでしょうか?
実は素では「if new_dice.length > 0」と書いていたらrubocop先生に「そこは .!empty? だろ」と訂正されたのでしたw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いえ、単に文法上
.!empty?
という記法がないです。そのためテストも全て失敗しています。if !new_dice.empty?
が正しかったんですね。unless
とif !
のどちらでも問題ないです、There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なんと!文法上存在しないものがrubocopから提示されるとは考えてもみなかったですね。
そういうこともあるんだなぁ。