Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared components project! #150

Merged
merged 17 commits into from
Jun 19, 2020
Merged

Shared components project! #150

merged 17 commits into from
Jun 19, 2020

Conversation

sdevalapurkar-bcgov
Copy link
Contributor

@sdevalapurkar-bcgov sdevalapurkar-bcgov commented Jun 18, 2020 •
edited
Loading

Description

This PR includes the following proposed change(s):

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation

How Has This Been Tested?

Locally

Credit

@adodge-bcg

@akroon3r akroon3r requested a review from wit-dan June 18, 2020 21:51
@sdevalapurkar-bcgov sdevalapurkar-bcgov requested review from TayGov, KFloodBCGov, akroon3r and alexjoybc and removed request for wit-dan June 18, 2020 21:51
akroon3r
akroon3r previously approved these changes Jun 18, 2020
View reviewed changes
@akroon3r
Copy link

FAIL src/storyshots.test.js
● Test suite failed to run

Cannot find module 'shared-components' from 'Home.js'

However, Jest was able to find:
	'./Home.js'
	'./Home.stories.js'

@akroon3r akroon3r closed this Jun 18, 2020
@akroon3r akroon3r reopened this Jun 18, 2020
@akroon3r
Copy link

whoops misclicked.

@sdevalapurkar-bcgov sdevalapurkar-bcgov added the LARGE Large PR label Jun 19, 2020
@akroon3r akroon3r merged commit bc4b133 into master Jun 19, 2020
@akroon3r akroon3r deleted the shared branch June 19, 2020 16:45
@akroon3r
Copy link

🚢 🚢 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adodge-bcg adodge-bcg adodge-bcg approved these changes

@TayGov TayGov Awaiting requested review from TayGov

@KFloodBCGov KFloodBCGov Awaiting requested review from KFloodBCGov

@alexjoybc alexjoybc Awaiting requested review from alexjoybc

@akroon3r akroon3r Awaiting requested review from akroon3r

Assignees

@sdevalapurkar-bcgov sdevalapurkar-bcgov

@adodge-bcg adodge-bcg

Labels
enhancement New feature or request frontend handle it HUGE LARGE Large PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdevalapurkar-bcgov @akroon3r @adodge-bcg